Skip to content

fix: Explicitly added client_id as an extra parameter causes bad token requests #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pnehrer
Copy link

@pnehrer pnehrer commented Jul 17, 2025

Fix #321 by omitting the addition of an extra client_id parameter.

Motivation and Context

Adding an extra client_id parameter to token endpoint request duplicates the client_id parameter, which the server then rejects with 400 Bad Request.

How Has This Been Tested?

I tested the fix using a customized example MCP client against a test MCP server that supports DCR.

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None.

@github-actions github-actions bot added T-core Core library changes T-transport Transport layer changes labels Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-core Core library changes T-transport Transport layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Explicitly added client_id as an extra parameter causes bad token requests
1 participant