-
Notifications
You must be signed in to change notification settings - Fork 408
Feat: Add agent skills #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wangxingjun778
commented
Oct 28, 2025
- Add core pipeline for running agent skills
- Add docs
- Add examples of skill and data
Summary of ChangesHello @wangxingjun778, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust and modular framework for integrating agent skills into the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant new feature: agent skills. The implementation is comprehensive, including a core pipeline for running skills, loading mechanisms, retrieval, and execution. The code is well-structured with good separation of concerns into different modules like loader, retriever, and schema. The addition of example skills and documentation is also very helpful.
My review focuses on improving robustness, fixing a few bugs, and enhancing maintainability. Key areas for improvement include safer command execution, correcting a bug in skill reloading, and avoiding side effects during context building. Overall, this is a solid foundation for the agent skills feature.