Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is broken since Node latest upgrade to 23.6.0 #2859

Open
web-padawan opened this issue Jan 10, 2025 · 0 comments
Open

Build is broken since Node latest upgrade to 23.6.0 #2859

web-padawan opened this issue Jan 10, 2025 · 0 comments

Comments

@web-padawan
Copy link
Contributor

There is a following error in the build for #2852 which I can also reproduce locally:

$ npm run test:node -w @web/test-runner-commands

> @web/[email protected] test:node
> mocha test/**/*.test.ts --require ts-node/register --reporter dot

(node:74652) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:74652) ExperimentalWarning: Type Stripping is an experimental feature and might change at any time
(node:74652) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/serhii/cf/modernweb/packages/test-runner-commands/test/a11y-snapshot/a11ySnapshotPlugin.test.ts is not specified and it doesn't parse as CommonJS.
Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
To eliminate this warning, add "type": "module" to /Users/serhii/cf/modernweb/packages/test-runner-commands/package.json.

file:///Users/serhii/cf/modernweb/packages/test-runner-commands/test/execute-server-command/executeServerCommand.test.ts:4
import { Logger } from '@web/dev-server-core';
         ^^^^^^
SyntaxError: The requested module '@web/dev-server-core' does not provide an export named 'Logger'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:181:21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant