Fix another issue with updates

fourjr · fourjr · commit a956073f06bf · 2020-11-14T21:02:13.000+08:00
diff --git a/bot.py b/bot.py
@@ -1484,7 +1484,7 @@ async def autoupdate(self):
                 res = await proc.stdout.read()
                 res = res.decode("utf-8").rstrip()
 
-                if err:
+                if err and not res:
                     logger.warning(f"Autoupdate failed: {err}")
                     self.autoupdate_loop.cancel()
                     return
diff --git a/cogs/utility.py b/cogs/utility.py
@@ -1926,7 +1926,7 @@ async def update(self, ctx, *, flag: str = ""):
                 res = await proc.stdout.read()
                 res = res.decode("utf-8").rstrip()
 
-                if err:
+                if err and not res:
                     embed = discord.Embed(
                         title="Update failed", description=err, color=self.bot.error_color
                     )

Original file line number	Diff line number	Diff line change
`@@ -1926,7 +1926,7 @@ async def update(self, ctx, *, flag: str = ""):`
`1926`	`1926`	`res = await proc.stdout.read()`
`1927`	`1927`	`res = res.decode("utf-8").rstrip()`
`1928`	`1928`
`1929`		`- if err:`
	`1929`	`+ if err and not res:`
`1930`	`1930`	`embed = discord.Embed(`
`1931`	`1931`	`title="Update failed", description=err, color=self.bot.error_color`
`1932`	`1932`	`)`