Skip to content

fixes related to output_LN1 and pooler_output #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes related to output_LN1 and pooler_output #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/modeling_bert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ def forward(
new_outputs = DecompXOutput(
attention=output_builder(summed_weighted_layer, decompx_config.output_attention),
res1=output_builder(residual_weighted_layer, decompx_config.output_res1),
LN1=output_builder(post_ln_layer, decompx_config.output_res2),
LN1=output_builder(post_ln_layer, decompx_config.output_LN1),
FFN=output_builder(post_ffn_layer, decompx_config.output_FFN),
res2=output_builder(pre_ln2_layer, decompx_config.output_res2),
encoder=output_builder(post_ln2_layer, "both")
Expand Down Expand Up @@ -1483,7 +1483,7 @@ def forward(
decompx_ready = decompx_config is not None
pooled_output = self.pooler(sequence_output, decompx_ready=decompx_ready) if self.pooler is not None else None

if decompx_ready:
if decompx_ready and pooled_output: # pooled output is None if not add_pooling_layer
pre_act_pooled = pooled_output[1]
pooled_output = pooled_output[0]

Expand Down
2 changes: 1 addition & 1 deletion src/modeling_roberta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ def forward(
new_outputs = DecompXOutput(
attention=output_builder(summed_weighted_layer, decompx_config.output_attention),
res1=output_builder(residual_weighted_layer, decompx_config.output_res1),
LN1=output_builder(post_ln_layer, decompx_config.output_res2),
LN1=output_builder(post_ln_layer, decompx_config.output_LN1),
FFN=output_builder(post_ffn_layer, decompx_config.output_FFN),
res2=output_builder(pre_ln2_layer, decompx_config.output_res2),
encoder=output_builder(post_ln2_layer, "both")
Expand Down