Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainability improvements and enhancements #10

Open
bodom0015 opened this issue Mar 21, 2023 · 0 comments
Open

Maintainability improvements and enhancements #10

bodom0015 opened this issue Mar 21, 2023 · 0 comments

Comments

@bodom0015
Copy link
Member

bodom0015 commented Mar 21, 2023

Capturing feedback from @manning-ncsa about the preliminary prototype:

Other items I noticed while reviewing the latest code version that I'll list here for reference:

  • Instead of modifying the existing job endpoint handler functions, duplicates with specific "CLEAN" names were created. This seems unnecessary and confusing.
  • In CLEANSubmitJobHandler "post" function, the BaseHandler.getarg() function is bypassed for some reason. Also this function semantically makes more sense as a PUT request as in the original.
  • Same comment for CLEANStatusJobHandler POST reverting to GET for semantic reasons
  • The command parameter is hard-coded in the kubejob.create_job() function instead of being set in the calling request handler function CLEANSubmitJobHandler which makes kubejob.create_job() unnecessarily specific.
  • There is a new APPCONFIG variable in main.py whose config info should instead be inserted into config/server.yaml where it can be accessed like all the other application config data, perhaps at YAML node uws.job.resultBaseUrl or similar

Some of this will be helped by using OpenAPI (as mentioned in #1), and will give more flexibility if a POST needs to change to a GET etc

@bodom0015 bodom0015 changed the title Capturing feedback and suggestions for API integration Maintainability improvements and enhancements Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant