forked from keybase/kbfs
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathconflict_resolver_test.go
1442 lines (1262 loc) · 46.3 KB
/
conflict_resolver_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"errors"
"reflect"
"testing"
"time"
"github.com/golang/mock/gomock"
"github.com/keybase/client/go/libkb"
"github.com/keybase/client/go/protocol/keybase1"
"github.com/keybase/kbfs/kbfscodec"
"github.com/keybase/kbfs/kbfscrypto"
"github.com/keybase/kbfs/kbfsmd"
"github.com/keybase/kbfs/tlf"
"github.com/stretchr/testify/require"
"golang.org/x/net/context"
)
func crTestInit(t *testing.T) (ctx context.Context, cancel context.CancelFunc,
mockCtrl *gomock.Controller, config *ConfigMock, cr *ConflictResolver) {
ctr := NewSafeTestReporter(t)
mockCtrl = gomock.NewController(ctr)
config = NewConfigMock(mockCtrl, ctr)
config.SetCodec(kbfscodec.NewMsgpack())
config.SetClock(wallClock{})
id := tlf.FakeID(1, tlf.Private)
fbo := newFolderBranchOps(
ctx, config, FolderBranch{id, MasterBranch}, standard)
// usernames don't matter for these tests
config.mockKbpki.EXPECT().GetNormalizedUsername(gomock.Any(), gomock.Any()).
AnyTimes().Return(libkb.NormalizedUsername("mockUser"), nil)
mockDaemon := NewMockKeybaseService(mockCtrl)
mockDaemon.EXPECT().LoadUserPlusKeys(
gomock.Any(), gomock.Any(), gomock.Any()).AnyTimes().Return(
UserInfo{Name: "mockUser"}, nil)
config.SetKeybaseService(mockDaemon)
timeoutCtx, cancel := context.WithTimeout(
context.Background(), individualTestTimeout)
initSuccess := false
defer func() {
if !initSuccess {
cancel()
}
}()
ctx, err := NewContextWithCancellationDelayer(NewContextReplayable(
timeoutCtx, func(c context.Context) context.Context {
return c
}))
if err != nil {
t.Fatal(err)
}
initSuccess = true
return ctx, cancel, mockCtrl, config, fbo.cr
}
func crTestShutdown(ctx context.Context, cancel context.CancelFunc,
mockCtrl *gomock.Controller, config *ConfigMock, cr *ConflictResolver) {
CleanupCancellationDelayer(ctx)
config.ctr.CheckForFailures()
cr.fbo.Shutdown(ctx)
cancel()
mockCtrl.Finish()
}
type failingCodec struct {
kbfscodec.Codec
}
func (fc failingCodec) Encode(interface{}) ([]byte, error) {
return nil, errors.New("Stopping resolution process early")
}
func crMakeFakeRMD(rev kbfsmd.Revision, bid kbfsmd.BranchID) ImmutableRootMetadata {
var writerFlags kbfsmd.WriterFlags
if bid != kbfsmd.NullBranchID {
writerFlags = kbfsmd.MetadataFlagUnmerged
}
key := kbfscrypto.MakeFakeVerifyingKeyOrBust("fake key")
return MakeImmutableRootMetadata(&RootMetadata{
bareMd: &kbfsmd.RootMetadataV2{
WriterMetadataV2: kbfsmd.WriterMetadataV2{
ID: tlf.FakeID(0x1, tlf.Private),
WFlags: writerFlags,
BID: bid,
},
WriterMetadataSigInfo: kbfscrypto.SignatureInfo{
VerifyingKey: key,
},
Revision: rev,
PrevRoot: kbfsmd.FakeID(byte(rev - 1)),
},
tlfHandle: &TlfHandle{name: "fake"},
}, key, kbfsmd.FakeID(byte(rev)), time.Now(), true)
}
func TestCRInput(t *testing.T) {
ctx, cancel, mockCtrl, config, cr := crTestInit(t)
defer crTestShutdown(ctx, cancel, mockCtrl, config, cr)
// First try a completely unknown revision
cr.Resolve(
ctx, kbfsmd.RevisionUninitialized, kbfsmd.RevisionUninitialized)
// This should return without doing anything (i.e., without
// calling any mock methods)
cr.Wait(ctx)
// Next, try resolving a few items
branchPoint := kbfsmd.Revision(2)
unmergedHead := kbfsmd.Revision(5)
mergedHead := kbfsmd.Revision(15)
crypto := MakeCryptoCommon(config.Codec())
bid, err := crypto.MakeRandomBranchID()
if err != nil {
t.Fatalf("Branch id err: %+v", bid)
}
cr.fbo.bid = bid
cr.fbo.head = crMakeFakeRMD(unmergedHead, bid)
cr.fbo.headStatus = headTrusted
// serve all the MDs from the cache
config.mockMdcache.EXPECT().Put(gomock.Any()).AnyTimes().Return(nil)
for i := unmergedHead; i >= branchPoint+1; i-- {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, bid).Return(
crMakeFakeRMD(i, bid), nil)
}
for i := kbfsmd.RevisionInitial; i <= branchPoint; i++ {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, bid).Return(
ImmutableRootMetadata{}, NoSuchMDError{cr.fbo.id(), branchPoint, bid})
}
config.mockMdops.EXPECT().GetUnmergedRange(gomock.Any(), cr.fbo.id(),
bid, kbfsmd.RevisionInitial, branchPoint).Return(nil, nil)
for i := branchPoint; i <= mergedHead; i++ {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, kbfsmd.NullBranchID).Return(
crMakeFakeRMD(i, kbfsmd.NullBranchID), nil)
}
for i := mergedHead + 1; i <= branchPoint-1+2*maxMDsAtATime; i++ {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, kbfsmd.NullBranchID).Return(
ImmutableRootMetadata{}, NoSuchMDError{cr.fbo.id(), i, kbfsmd.NullBranchID})
}
config.mockMdops.EXPECT().GetRange(gomock.Any(), cr.fbo.id(), mergedHead+1,
gomock.Any(), nil).Return(nil, nil)
// CR doesn't see any operations and so it does resolution early.
// Just cause an error so it doesn't bother the mocks too much.
config.SetCodec(failingCodec{config.Codec()})
config.mockRep.EXPECT().ReportErr(gomock.Any(), gomock.Any(),
gomock.Any(), gomock.Any(), gomock.Any())
// First try a completely unknown revision
cr.Resolve(ctx, unmergedHead, kbfsmd.RevisionUninitialized)
cr.Wait(ctx)
// Make sure sure the input is up-to-date
if cr.currInput.merged != mergedHead {
t.Fatalf("Unexpected merged input: %d", cr.currInput.merged)
}
// Now make sure we ignore future inputs with lesser MDs
cr.Resolve(ctx, kbfsmd.RevisionUninitialized, mergedHead-1)
// This should return without doing anything (i.e., without
// calling any mock methods)
cr.Wait(ctx)
}
func TestCRInputFracturedRange(t *testing.T) {
ctx, cancel, mockCtrl, config, cr := crTestInit(t)
defer crTestShutdown(ctx, cancel, mockCtrl, config, cr)
// Next, try resolving a few items
branchPoint := kbfsmd.Revision(2)
unmergedHead := kbfsmd.Revision(5)
mergedHead := kbfsmd.Revision(15)
crypto := MakeCryptoCommon(config.Codec())
bid, err := crypto.MakeRandomBranchID()
if err != nil {
t.Fatalf("Branch id err: %+v", bid)
}
cr.fbo.bid = bid
cr.fbo.head = crMakeFakeRMD(unmergedHead, bid)
cr.fbo.headStatus = headTrusted
// serve all the MDs from the cache
config.mockMdcache.EXPECT().Put(gomock.Any()).AnyTimes().Return(nil)
for i := unmergedHead; i >= branchPoint+1; i-- {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, bid).Return(crMakeFakeRMD(i, bid), nil)
}
for i := kbfsmd.RevisionInitial; i <= branchPoint; i++ {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, bid).Return(
ImmutableRootMetadata{}, NoSuchMDError{cr.fbo.id(), branchPoint, bid})
}
config.mockMdops.EXPECT().GetUnmergedRange(gomock.Any(), cr.fbo.id(),
bid, kbfsmd.RevisionInitial, branchPoint).Return(nil, nil)
skipCacheRevision := kbfsmd.Revision(10)
for i := branchPoint; i <= mergedHead; i++ {
// Pretend that revision 10 isn't in the cache, and needs to
// be fetched from the server.
if i != skipCacheRevision {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i,
kbfsmd.NullBranchID).Return(crMakeFakeRMD(i, kbfsmd.NullBranchID), nil)
} else {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i,
kbfsmd.NullBranchID).Return(
ImmutableRootMetadata{}, NoSuchMDError{cr.fbo.id(), i, kbfsmd.NullBranchID})
}
}
config.mockMdops.EXPECT().GetRange(gomock.Any(), cr.fbo.id(),
skipCacheRevision, skipCacheRevision, gomock.Any()).Return(
[]ImmutableRootMetadata{crMakeFakeRMD(skipCacheRevision, kbfsmd.NullBranchID)}, nil)
for i := mergedHead + 1; i <= branchPoint-1+2*maxMDsAtATime; i++ {
config.mockMdcache.EXPECT().Get(cr.fbo.id(), i, kbfsmd.NullBranchID).Return(
ImmutableRootMetadata{}, NoSuchMDError{cr.fbo.id(), i, kbfsmd.NullBranchID})
}
config.mockMdops.EXPECT().GetRange(gomock.Any(), cr.fbo.id(), mergedHead+1,
gomock.Any(), gomock.Any()).Return(nil, nil)
// CR doesn't see any operations and so it does resolution early.
// Just cause an error so it doesn't bother the mocks too much.
config.SetCodec(failingCodec{config.Codec()})
config.mockRep.EXPECT().ReportErr(gomock.Any(), gomock.Any(),
gomock.Any(), gomock.Any(), gomock.Any())
// Resolve the fractured revision list
cr.Resolve(ctx, unmergedHead, kbfsmd.RevisionUninitialized)
cr.Wait(ctx)
// Make sure sure the input is up-to-date
if cr.currInput.merged != mergedHead {
t.Fatalf("Unexpected merged input: %d", cr.currInput.merged)
}
}
func testCRSharedFolderForUsers(
t *testing.T, ctx context.Context, name string, createAs keybase1.UID,
configs map[keybase1.UID]Config, dirs []string) map[keybase1.UID]Node {
nodes := make(map[keybase1.UID]Node)
// create by the first user
kbfsOps := configs[createAs].KBFSOps()
rootNode := GetRootNodeOrBust(ctx, t, configs[createAs], name, tlf.Private)
dir := rootNode
for _, d := range dirs {
dirNext, _, err := kbfsOps.CreateDir(ctx, dir, d)
if _, ok := err.(NameExistsError); ok {
dirNext, _, err = kbfsOps.Lookup(ctx, dir, d)
if err != nil {
t.Fatalf("Couldn't lookup dir: %v", err)
}
} else if err != nil {
t.Fatalf("Couldn't create dir: %v", err)
}
dir = dirNext
}
err := kbfsOps.SyncAll(ctx, rootNode.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
nodes[createAs] = dir
for u, config := range configs {
if u == createAs {
continue
}
kbfsOps := config.KBFSOps()
kbfsOps.SyncFromServer(ctx, rootNode.GetFolderBranch(), nil)
rootNode := GetRootNodeOrBust(ctx, t, config, name, tlf.Private)
dir := rootNode
for _, d := range dirs {
var err error
dir, _, err = kbfsOps.Lookup(ctx, dir, d)
if err != nil {
t.Fatalf("Couldn't lookup dir: %v", err)
}
}
nodes[u] = dir
}
return nodes
}
func testCRCheckPathsAndActions(t *testing.T, cr *ConflictResolver,
expectedUnmergedPaths []path, expectedMergedPaths map[BlockPointer]path,
expectedRecreateOps []*createOp,
expectedActions map[BlockPointer]crActionList) {
ctx := BackgroundContextWithCancellationDelayer()
defer CleanupCancellationDelayer(ctx)
lState := makeFBOLockState()
// Step 1 -- check the chains and paths
unmergedChains, mergedChains, unmergedPaths, mergedPaths,
recreateOps, _, _, err := cr.buildChainsAndPaths(ctx, lState, false)
if err != nil {
t.Fatalf("Couldn't build chains and paths: %v", err)
}
// we don't care about the order of the unmerged paths, so put
// them into maps for comparison
eUPathMap := make(map[BlockPointer]path)
for _, p := range expectedUnmergedPaths {
eUPathMap[p.tailPointer()] = p
}
uPathMap := make(map[BlockPointer]path)
for _, p := range unmergedPaths {
uPathMap[p.tailPointer()] = p
}
if !reflect.DeepEqual(eUPathMap, uPathMap) {
t.Fatalf("Unmerged paths aren't right. Expected %v, got %v",
expectedUnmergedPaths, unmergedPaths)
}
if !reflect.DeepEqual(expectedMergedPaths, mergedPaths) {
for k, v := range expectedMergedPaths {
t.Logf("Expected: %v -> %v", k, v.path)
t.Logf("Got: %v -> %v", k, mergedPaths[k].path)
}
t.Fatalf("Merged paths aren't right. Expected %v, got %v",
expectedMergedPaths, mergedPaths)
}
if g, e := len(recreateOps), len(expectedRecreateOps); g != e {
t.Fatalf("Different number of recreate ops: %d vs %d", g, e)
}
// Can't use reflect.DeepEqual on the array since these contain
// pointers which will always differ.
for i, op := range expectedRecreateOps {
if g, e := *recreateOps[i], *op; g.Dir.Unref != e.Dir.Unref ||
g.NewName != e.NewName || g.Type != e.Type {
t.Fatalf("Unexpected op at index %d: %v vs %v", i, g, e)
}
}
// Now for step 2 -- check the actions
actionMap, _, err := cr.computeActions(
ctx, unmergedChains, mergedChains,
unmergedPaths, mergedPaths, recreateOps, writerInfo{})
if err != nil {
t.Fatalf("Couldn't compute actions: %v", err)
}
if expectedActions == nil {
return
}
// Set writer infos to match so DeepEqual will succeed.
for k, v := range expectedActions {
v2, ok := actionMap[k]
if !ok || (len(v) != len(v2)) {
break
}
for i := 0; i < len(v); i++ {
switch x := v[i].(type) {
case *dropUnmergedAction:
y := v2[i].(*dropUnmergedAction)
y.op.setWriterInfo(x.op.getWriterInfo())
}
}
}
if !reflect.DeepEqual(expectedActions, actionMap) {
for k, v := range expectedActions {
t.Logf("Sub %v eq=%v", k, reflect.DeepEqual(v, actionMap[k]))
t.Logf("Expected: %v", v)
t.Logf("Got: %v", actionMap[k])
}
t.Fatalf("Actions aren't right. Expected %v, got %v",
expectedActions, actionMap)
}
}
func testCRGetCROrBust(t *testing.T, config Config,
fb FolderBranch) *ConflictResolver {
kbfsOpsCast, ok := config.KBFSOps().(*KBFSOpsStandard)
if !ok {
t.Fatalf("Unexpected KBFSOps type")
}
ops := kbfsOpsCast.getOpsNoAdd(context.TODO(), fb)
return ops.cr
}
// Make two users, u1 and u2, with some common directories in a shared
// folder. Pause updates on u2, and have both users make different
// updates in a shared subdirectory. Then run through the first few
// conflict resolution steps directly through u2's conflict resolver
// and make sure the resulting unmerged path maps correctly to the
// merged path.
func TestCRMergedChainsSimple(t *testing.T) {
var userName1, userName2 libkb.NormalizedUsername = "u1", "u2"
config1, uid1, ctx, cancel := kbfsOpsConcurInit(t, userName1, userName2)
defer kbfsConcurTestShutdown(t, config1, ctx, cancel)
config2 := ConfigAsUser(config1, userName2)
defer CheckConfigAndShutdown(ctx, t, config2)
session2, err := config2.KBPKI().GetCurrentSession(ctx)
if err != nil {
t.Fatal(err)
}
uid2 := session2.UID
name := userName1.String() + "," + userName2.String()
configs := make(map[keybase1.UID]Config)
configs[uid1] = config1
configs[uid2] = config2
nodes := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dir"})
dir1 := nodes[uid1]
dir2 := nodes[uid2]
fb := dir1.GetFolderBranch()
// pause user 2
_, err = DisableUpdatesForTesting(config2, fb)
if err != nil {
t.Fatalf("Can't disable updates for user 2: %v", err)
}
// user1 makes a file
_, _, err = config1.KBFSOps().CreateFile(ctx, dir1, "file1", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dir1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
cr1 := testCRGetCROrBust(t, config1, fb)
cr2 := testCRGetCROrBust(t, config2, fb)
cr2.Shutdown()
// user2 makes a file (causes a conflict, and goes unstaged)
_, _, err = config2.KBFSOps().CreateFile(ctx, dir2, "file2", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config2.KBFSOps().SyncAll(ctx, dir2.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// Now step through conflict resolution manually for user 2
mergedPaths := make(map[BlockPointer]path)
expectedUnmergedPath := cr2.fbo.nodeCache.PathFromNode(dir2)
mergedPath := cr1.fbo.nodeCache.PathFromNode(dir1)
mergedPaths[expectedUnmergedPath.tailPointer()] = mergedPath
expectedActions := map[BlockPointer]crActionList{
mergedPath.tailPointer(): {©UnmergedEntryAction{
"file2", "file2", "", false, false, DirEntry{}, nil}},
}
testCRCheckPathsAndActions(t, cr2, []path{expectedUnmergedPath},
mergedPaths, nil, expectedActions)
}
// Same as TestCRMergedChainsSimple, but the two users make changes in
// different, unrelated subdirectories, forcing the resolver to use
// mostly original block pointers when constructing the merged path.
func TestCRMergedChainsDifferentDirectories(t *testing.T) {
var userName1, userName2 libkb.NormalizedUsername = "u1", "u2"
config1, uid1, ctx, cancel := kbfsOpsConcurInit(t, userName1, userName2)
defer kbfsConcurTestShutdown(t, config1, ctx, cancel)
config2 := ConfigAsUser(config1, userName2)
defer CheckConfigAndShutdown(ctx, t, config2)
session2, err := config2.KBPKI().GetCurrentSession(ctx)
if err != nil {
t.Fatal(err)
}
uid2 := session2.UID
name := userName1.String() + "," + userName2.String()
configs := make(map[keybase1.UID]Config)
configs[uid1] = config1
configs[uid2] = config2
nodesA := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirA"})
dirA1 := nodesA[uid1]
nodesB := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirB"})
dirB1 := nodesB[uid1]
dirB2 := nodesB[uid2]
fb := dirA1.GetFolderBranch()
// pause user 2
_, err = DisableUpdatesForTesting(config2, fb)
if err != nil {
t.Fatalf("Can't disable updates for user 2: %v", err)
}
// user1 makes a file in dir A
_, _, err = config1.KBFSOps().CreateFile(ctx, dirA1, "file1", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dirA1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
cr1 := testCRGetCROrBust(t, config1, fb)
cr2 := testCRGetCROrBust(t, config2, fb)
cr2.Shutdown()
// user2 makes a file in dir B
_, _, err = config2.KBFSOps().CreateFile(ctx, dirB2, "file2", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config2.KBFSOps().SyncAll(ctx, dirB2.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// Now step through conflict resolution manually for user 2
mergedPaths := make(map[BlockPointer]path)
expectedUnmergedPath := cr2.fbo.nodeCache.PathFromNode(dirB2)
mergedPath := cr1.fbo.nodeCache.PathFromNode(dirB1)
mergedPaths[expectedUnmergedPath.tailPointer()] = mergedPath
expectedActions := map[BlockPointer]crActionList{
mergedPath.tailPointer(): {©UnmergedEntryAction{
"file2", "file2", "", false, false, DirEntry{}, nil}},
}
testCRCheckPathsAndActions(t, cr2, []path{expectedUnmergedPath},
mergedPaths, nil, expectedActions)
}
// Same as TestCRMergedChainsSimple, but u1 actually deletes some of
// the subdirectories used by u2, forcing the resolver to generate
// some recreateOps.
func TestCRMergedChainsDeletedDirectories(t *testing.T) {
var userName1, userName2 libkb.NormalizedUsername = "u1", "u2"
config1, uid1, ctx, cancel := kbfsOpsConcurInit(t, userName1, userName2)
defer kbfsConcurTestShutdown(t, config1, ctx, cancel)
config2 := ConfigAsUser(config1, userName2)
defer CheckConfigAndShutdown(ctx, t, config2)
session2, err := config2.KBPKI().GetCurrentSession(ctx)
if err != nil {
t.Fatal(err)
}
uid2 := session2.UID
name := userName1.String() + "," + userName2.String()
configs := make(map[keybase1.UID]Config)
configs[uid1] = config1
configs[uid2] = config2
nodesA := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirA"})
dirA1 := nodesA[uid1]
fb := dirA1.GetFolderBranch()
cr1 := testCRGetCROrBust(t, config1, fb)
cr2 := testCRGetCROrBust(t, config2, fb)
cr2.Shutdown()
nodesB := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB"})
dirB1 := nodesB[uid1]
nodesC := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB", "dirC"})
dirC2 := nodesC[uid2]
dirAPtr := cr1.fbo.nodeCache.PathFromNode(dirA1).tailPointer()
dirBPtr := cr1.fbo.nodeCache.PathFromNode(dirB1).tailPointer()
dirCPtr := cr2.fbo.nodeCache.PathFromNode(dirC2).tailPointer()
// pause user 2
_, err = DisableUpdatesForTesting(config2, fb)
if err != nil {
t.Fatalf("Can't disable updates for user 2: %v", err)
}
// user1 deletes dirB and dirC
err = config1.KBFSOps().RemoveDir(ctx, dirB1, "dirC")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config1.KBFSOps().RemoveDir(ctx, dirA1, "dirB")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dirB1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// user2 makes a file in dir C
_, _, err = config2.KBFSOps().CreateFile(ctx, dirC2, "file2", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config2.KBFSOps().SyncAll(ctx, dirC2.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// Now step through conflict resolution manually for user 2
expectedUnmergedPath := cr2.fbo.nodeCache.PathFromNode(dirC2)
// The merged path will consist of the latest root and dirA
// components, plus the original blockpointers of the deleted
// nodes.
mergedPaths := make(map[BlockPointer]path)
mergedPath := cr1.fbo.nodeCache.PathFromNode(dirA1)
mergedPath.path = append(mergedPath.path, pathNode{
BlockPointer: dirBPtr,
Name: "dirB",
})
mergedPath.path = append(mergedPath.path, pathNode{
BlockPointer: dirCPtr,
Name: "dirC",
})
mergedPaths[expectedUnmergedPath.tailPointer()] = mergedPath
coB, err := newCreateOp("dirB", dirAPtr, Dir)
require.NoError(t, err)
coC, err := newCreateOp("dirC", dirBPtr, Dir)
require.NoError(t, err)
dirAPtr1 := cr1.fbo.nodeCache.PathFromNode(dirA1).tailPointer()
expectedActions := map[BlockPointer]crActionList{
dirCPtr: {©UnmergedEntryAction{"file2", "file2", "",
false, false, DirEntry{}, nil}},
dirBPtr: {©UnmergedEntryAction{"dirC", "dirC", "", false, false,
DirEntry{}, nil}},
dirAPtr1: {©UnmergedEntryAction{"dirB", "dirB", "", false, false,
DirEntry{}, nil}},
}
testCRCheckPathsAndActions(t, cr2, []path{expectedUnmergedPath},
mergedPaths, []*createOp{coB, coC}, expectedActions)
}
// Same as TestCRMergedChainsSimple, but u1 actually renames one of
// the subdirectories used by u2, forcing the resolver to follow the
// path across the rename.
func TestCRMergedChainsRenamedDirectory(t *testing.T) {
var userName1, userName2 libkb.NormalizedUsername = "u1", "u2"
config1, uid1, ctx, cancel := kbfsOpsConcurInit(t, userName1, userName2)
defer kbfsConcurTestShutdown(t, config1, ctx, cancel)
config2 := ConfigAsUser(config1, userName2)
defer CheckConfigAndShutdown(ctx, t, config2)
session2, err := config2.KBPKI().GetCurrentSession(ctx)
if err != nil {
t.Fatal(err)
}
uid2 := session2.UID
name := userName1.String() + "," + userName2.String()
configs := make(map[keybase1.UID]Config)
configs[uid1] = config1
configs[uid2] = config2
nodesA := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirA"})
dirA1 := nodesA[uid1]
fb := dirA1.GetFolderBranch()
cr1 := testCRGetCROrBust(t, config1, fb)
cr2 := testCRGetCROrBust(t, config2, fb)
cr2.Shutdown()
nodesB := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB"})
dirB1 := nodesB[uid1]
nodesC := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB", "dirC"})
dirC1 := nodesC[uid1]
dirC2 := nodesC[uid2]
dirCPtr := cr1.fbo.nodeCache.PathFromNode(dirC1).tailPointer()
// pause user 2
_, err = DisableUpdatesForTesting(config2, fb)
if err != nil {
t.Fatalf("Can't disable updates for user 2: %v", err)
}
// user1 makes /dirA/dirD and renames dirC into it
dirD1, _, err := config1.KBFSOps().CreateDir(ctx, dirA1, "dirD")
if err != nil {
t.Fatalf("Couldn't make dir: %v", err)
}
err = config1.KBFSOps().Rename(ctx, dirB1, "dirC", dirD1, "dirC")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dirA1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// user2 makes a file in dir C
_, _, err = config2.KBFSOps().CreateFile(ctx, dirC2, "file2", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config2.KBFSOps().SyncAll(ctx, dirC2.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// Now step through conflict resolution manually for user 2
expectedUnmergedPath := cr2.fbo.nodeCache.PathFromNode(dirC2)
// The merged path will be the dirD/dirC path
mergedPaths := make(map[BlockPointer]path)
mergedPath := cr1.fbo.nodeCache.PathFromNode(dirD1)
mergedPath.path = append(mergedPath.path, pathNode{
BlockPointer: dirCPtr,
Name: "dirC",
})
mergedPaths[expectedUnmergedPath.tailPointer()] = mergedPath
expectedActions := map[BlockPointer]crActionList{
mergedPath.tailPointer(): {©UnmergedEntryAction{
"file2", "file2", "", false, false, DirEntry{}, nil}},
}
testCRCheckPathsAndActions(t, cr2, []path{expectedUnmergedPath},
mergedPaths, nil, expectedActions)
}
// A mix of the above TestCRMergedChains* tests, with various other
// types of operations thrown in the mix (like u2 deleting unrelated
// directories, etc).
func TestCRMergedChainsComplex(t *testing.T) {
var userName1, userName2 libkb.NormalizedUsername = "u1", "u2"
config1, uid1, ctx, cancel := kbfsOpsConcurInit(t, userName1, userName2)
defer kbfsConcurTestShutdown(t, config1, ctx, cancel)
config2 := ConfigAsUser(config1, userName2)
defer CheckConfigAndShutdown(ctx, t, config2)
session2, err := config2.KBPKI().GetCurrentSession(ctx)
if err != nil {
t.Fatal(err)
}
uid2 := session2.UID
// Setup:
// /dirA/dirB/dirC
// /dirA/dirB/dirD/file5
// /dirE/dirF
// /dirG/dirH
name := userName1.String() + "," + userName2.String()
configs := make(map[keybase1.UID]Config)
configs[uid1] = config1
configs[uid2] = config2
nodesA := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirA"})
dirA1 := nodesA[uid1]
dirA2 := nodesA[uid2]
fb := dirA1.GetFolderBranch()
cr1 := testCRGetCROrBust(t, config1, fb)
cr2 := testCRGetCROrBust(t, config2, fb)
cr2.Shutdown()
nodesB := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB"})
dirB1 := nodesB[uid1]
dirB2 := nodesB[uid2]
nodesC := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB", "dirC"})
dirC2 := nodesC[uid2]
nodesD := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirA", "dirB", "dirD"})
dirD1 := nodesD[uid1]
dirD2 := nodesD[uid2]
nodesE := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirE"})
dirE1 := nodesE[uid1]
nodesF := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirE", "dirF"})
dirF2 := nodesF[uid2]
dirEPtr := cr2.fbo.nodeCache.PathFromNode(dirE1).tailPointer()
dirFPtr := cr2.fbo.nodeCache.PathFromNode(dirF2).tailPointer()
nodesG := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"dirG"})
dirG1 := nodesG[uid1]
nodesH := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"dirG", "dirH"})
dirH1 := nodesH[uid1]
dirH2 := nodesH[uid2]
dirHPtr := cr1.fbo.nodeCache.PathFromNode(dirH1).tailPointer()
_, _, err = config1.KBFSOps().CreateFile(ctx, dirD1, "file5", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dirD1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
config2.KBFSOps().SyncFromServer(ctx, fb, nil)
// pause user 2
_, err = DisableUpdatesForTesting(config2, fb)
if err != nil {
t.Fatalf("Can't disable updates for user 2: %v", err)
}
// user 1:
// touch /dirA/file1
// rm -rf /dirE/dirF
// mv /dirG/dirH /dirA/dirI
//
// user 2:
// mkdir /dirA/dirJ
// touch /dirA/dirJ/file2
// touch /dirE/dirF/file3
// touch /dirA/dirB/dirC/file4
// mv /dirA/dirB/dirC/file4 /dirG/dirH/file4
// rm /dirA/dirB/dirD/file5
// rm -rf /dirA/dirB/dirD
// user 1:
_, _, err = config1.KBFSOps().CreateFile(ctx, dirA1, "file1", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config1.KBFSOps().RemoveDir(ctx, dirE1, "dirF")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config1.KBFSOps().Rename(ctx, dirG1, "dirH", dirA1, "dirI")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dirA1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// user2
dirJ2, _, err := config2.KBFSOps().CreateDir(ctx, dirA2, "dirJ")
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
_, _, err = config2.KBFSOps().CreateFile(ctx, dirJ2, "file2", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
_, _, err = config2.KBFSOps().CreateFile(ctx, dirF2, "file3", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
_, _, err = config2.KBFSOps().CreateFile(ctx, dirC2, "file4", false, NoExcl)
if err != nil {
t.Fatalf("Couldn't create file: %v", err)
}
err = config2.KBFSOps().Rename(ctx, dirC2, "file4", dirH2, "file4")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config2.KBFSOps().RemoveEntry(ctx, dirD2, "file5")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config2.KBFSOps().RemoveDir(ctx, dirB2, "dirD")
if err != nil {
t.Fatalf("Couldn't remove dir: %v", err)
}
err = config2.KBFSOps().SyncAll(ctx, dirB2.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// Now step through conflict resolution manually for user 2
uPathA2 := cr2.fbo.nodeCache.PathFromNode(dirA2)
uPathF2 := cr2.fbo.nodeCache.PathFromNode(dirF2)
// no expected unmerged path for dirJ or dirC
uPathH2 := cr2.fbo.nodeCache.PathFromNode(dirH2)
// no expected unmerged path for dirD
uPathB2 := cr2.fbo.nodeCache.PathFromNode(dirB2)
mergedPaths := make(map[BlockPointer]path)
// Both users updated A
mergedPathA := cr1.fbo.nodeCache.PathFromNode(dirA1)
mergedPaths[uPathA2.tailPointer()] = mergedPathA
// user 1 deleted dirF, so reconstruct
mergedPathF := cr1.fbo.nodeCache.PathFromNode(dirE1)
mergedPathF.path = append(mergedPathF.path, pathNode{
BlockPointer: dirFPtr,
Name: "dirF",
})
mergedPaths[uPathF2.tailPointer()] = mergedPathF
// dirH from user 2 is /dirA/dirI for user 1
mergedPathH := cr1.fbo.nodeCache.PathFromNode(dirA1)
mergedPathH.path = append(mergedPathH.path, pathNode{
BlockPointer: dirHPtr,
Name: "dirI",
})
mergedPaths[uPathH2.tailPointer()] = mergedPathH
// dirB wasn't touched by user 1
mergedPathB := cr1.fbo.nodeCache.PathFromNode(dirB1)
mergedPaths[uPathB2.tailPointer()] = mergedPathB
coF, err := newCreateOp("dirF", dirEPtr, Dir)
require.NoError(t, err)
mergedPathE := cr1.fbo.nodeCache.PathFromNode(dirE1)
expectedActions := map[BlockPointer]crActionList{
mergedPathA.tailPointer(): {©UnmergedEntryAction{
"dirJ", "dirJ", "", false, false, DirEntry{}, nil}},
mergedPathE.tailPointer(): {©UnmergedEntryAction{
"dirF", "dirF", "", false, false, DirEntry{}, nil}},
mergedPathF.tailPointer(): {©UnmergedEntryAction{
"file3", "file3", "", false, false, DirEntry{}, nil}},
mergedPathH.tailPointer(): {©UnmergedEntryAction{
"file4", "file4", "", false, false, DirEntry{}, nil}},
mergedPathB.tailPointer(): {&rmMergedEntryAction{"dirD"}},
}
// `rm file5` doesn't get an action because the parent directory
// was deleted in the unmerged branch.
testCRCheckPathsAndActions(t, cr2, []path{uPathA2, uPathF2, uPathH2,
uPathB2}, mergedPaths, []*createOp{coF}, expectedActions)
}
// Tests that conflict resolution detects and can fix rename cycles.
func TestCRMergedChainsRenameCycleSimple(t *testing.T) {
var userName1, userName2 libkb.NormalizedUsername = "u1", "u2"
config1, uid1, ctx, cancel := kbfsOpsConcurInit(t, userName1, userName2)
defer kbfsConcurTestShutdown(t, config1, ctx, cancel)
clock, now := newTestClockAndTimeNow()
config1.SetClock(clock)
config2 := ConfigAsUser(config1, userName2)
defer CheckConfigAndShutdown(ctx, t, config2)
session2, err := config2.KBPKI().GetCurrentSession(ctx)
if err != nil {
t.Fatal(err)
}
uid2 := session2.UID
name := userName1.String() + "," + userName2.String()
configs := make(map[keybase1.UID]Config)
configs[uid1] = config1
configs[uid2] = config2
nodesRoot := testCRSharedFolderForUsers(t, ctx, name, uid1, configs, []string{"root"})
dirRoot1 := nodesRoot[uid1]
dirRoot2 := nodesRoot[uid2]
fb := dirRoot1.GetFolderBranch()
nodesA := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"root", "dirA"})
dirA1 := nodesA[uid1]
nodesB := testCRSharedFolderForUsers(t, ctx, name, uid1, configs,
[]string{"root", "dirB"})
dirB1 := nodesB[uid1]
dirB2 := nodesB[uid2]
cr1 := testCRGetCROrBust(t, config1, fb)
cr2 := testCRGetCROrBust(t, config2, fb)
cr2.Shutdown()
// pause user 2
_, err = DisableUpdatesForTesting(config2, fb)
if err != nil {
t.Fatalf("Can't disable updates for user 2: %v", err)
}
// user1 moves dirB into dirA
err = config1.KBFSOps().Rename(ctx, dirRoot1, "dirB", dirA1, "dirB")
if err != nil {
t.Fatalf("Couldn't make dir: %v", err)
}
err = config1.KBFSOps().SyncAll(ctx, dirRoot1.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// user2 moves dirA into dirB
err = config2.KBFSOps().Rename(ctx, dirRoot2, "dirA", dirB2, "dirA")
if err != nil {
t.Fatalf("Couldn't make dir: %v", err)
}
err = config2.KBFSOps().SyncAll(ctx, dirRoot2.GetFolderBranch())
if err != nil {
t.Fatalf("Couldn't sync all: %v", err)
}
// Now step through conflict resolution manually for user 2
mergedPaths := make(map[BlockPointer]path)
// root
unmergedPathRoot := cr2.fbo.nodeCache.PathFromNode(dirRoot2)
mergedPathRoot := cr1.fbo.nodeCache.PathFromNode(dirRoot1)
mergedPaths[unmergedPathRoot.tailPointer()] = mergedPathRoot
unmergedPathB := cr2.fbo.nodeCache.PathFromNode(dirB2)
mergedPathB := cr1.fbo.nodeCache.PathFromNode(dirB1)
mergedPaths[unmergedPathB.tailPointer()] = mergedPathB