Skip to content

Commit 6d11d98

Browse files
committed
fix: remove desktop welcome changes
1 parent 2f900ab commit 6d11d98

File tree

3 files changed

+8
-59
lines changed

3 files changed

+8
-59
lines changed

packages/compass-components/src/components/context-menu.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,7 @@ export function ContextMenu({ menu }: ContextMenuWrapperProps) {
4343
<Menu
4444
renderMode="inline"
4545
open={menu.isOpen}
46-
setOpen={(open) => {
47-
if (!open) {
48-
menu.close();
49-
}
50-
}}
46+
setOpen={menu.close}
5147
justify="start"
5248
>
5349
{itemGroups.map(
@@ -65,8 +61,8 @@ export function ContextMenu({ menu }: ContextMenuWrapperProps) {
6561
data-text={item.label}
6662
data-testid={`menu-group-${groupIndex}-item-${itemIndex}`}
6763
onClick={(evt: React.MouseEvent) => {
68-
menu.close();
6964
item.onAction?.(evt);
65+
menu.close();
7066
}}
7167
>
7268
{item.label}

packages/compass-crud/src/components/crud-toolbar.spec.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import sinon from 'sinon';
44
import {
55
render,
66
screen,
7+
cleanup,
78
within,
89
userEvent,
910
} from '@mongodb-js/testing-library-compass';
@@ -69,7 +70,7 @@ describe('CrudToolbar Component', function () {
6970
onResetClicked={noop}
7071
onUpdateButtonClicked={noop}
7172
onDeleteButtonClicked={noop}
72-
onExpandAllClicked={props?.onExpandAllClicked || noop}
73+
onExpandAllClicked={noop}
7374
onCollapseAllClicked={noop}
7475
openExportFileDialog={noop}
7576
outdated={false}
@@ -89,6 +90,10 @@ describe('CrudToolbar Component', function () {
8990
);
9091
}
9192

93+
afterEach(function () {
94+
cleanup();
95+
});
96+
9297
beforeEach(async function () {
9398
preferences = await createSandboxFromDefaultPreferences();
9499
});

packages/compass-welcome/src/components/desktop-welcome-tab.tsx

Lines changed: 0 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import {
1414
cx,
1515
useDarkMode,
1616
Icon,
17-
useContextMenuItems,
1817
} from '@mongodb-js/compass-components';
1918
import { useTelemetry } from '@mongodb-js/compass-telemetry/provider';
2019
import { useConnectionActions } from '@mongodb-js/compass-connections/provider';
@@ -69,16 +68,6 @@ const createClusterButtonLightModeStyles = css({
6968
function AtlasHelpSection(): React.ReactElement {
7069
const track = useTelemetry();
7170
const darkMode = useDarkMode();
72-
const contextRef = useContextMenuItems([
73-
{
74-
label: 'Parent 1',
75-
onAction: () => console.log('Atlas Link Clicked', { screen: 'connect' }),
76-
},
77-
{
78-
label: 'Parent 2',
79-
onAction: () => console.log('Atlas Link Clicked', { screen: 'connect' }),
80-
},
81-
]);
8271

8372
return (
8473
<div
@@ -87,7 +76,6 @@ function AtlasHelpSection(): React.ReactElement {
8776
atlasContainerStyles,
8877
darkMode && atlasContainerDarkModeStyles
8978
)}
90-
ref={contextRef}
9179
data-testid="welcome-tab-atlas-help-section"
9280
>
9381
<Subtitle className={titleStyles}>
@@ -120,35 +108,6 @@ function AtlasHelpSection(): React.ReactElement {
120108
);
121109
}
122110

123-
function TestClusterButton() {
124-
const track = useTelemetry();
125-
const darkMode = useDarkMode();
126-
const contextRef = useContextMenuItems([
127-
{
128-
label: 'Child',
129-
onAction: () => console.log('Atlas Link Clicked', { screen: 'connect' }),
130-
},
131-
]);
132-
return (
133-
<div className={createClusterContainerStyles}>
134-
<Button
135-
ref={contextRef}
136-
data-testid="atlas-cta-link"
137-
className={cx(
138-
createClusterButtonStyles,
139-
!darkMode && createClusterButtonLightModeStyles
140-
)}
141-
onClick={() => track('Atlas Link Clicked', { screen: 'connect' })}
142-
variant={ButtonVariant.PrimaryOutline}
143-
href="https://www.mongodb.com/cloud/atlas/lp/try4?utm_source=compass&utm_medium=product&utm_content=v1"
144-
target="_blank"
145-
size={ButtonSize.Small}
146-
>
147-
CREATE FREE CLUSTER
148-
</Button>
149-
</div>
150-
);
151-
}
152111
const welcomeTabStyles = css({
153112
display: 'flex',
154113
alignItems: 'center',
@@ -166,17 +125,6 @@ export default function DesktopWelcomeTab() {
166125
const enableCreatingNewConnections = usePreference(
167126
'enableCreatingNewConnections'
168127
);
169-
const track = useTelemetry();
170-
const contextRef = useContextMenuItems([
171-
{
172-
label: 'Grandparent 1',
173-
onAction: () => track('Atlas Link Clicked', { screen: 'connect' }),
174-
},
175-
{
176-
label: 'Grandparent 2',
177-
onAction: () => track('Atlas Link Clicked', { screen: 'connect' }),
178-
},
179-
]);
180128

181129
return (
182130
<div className={welcomeTabStyles}>

0 commit comments

Comments
 (0)