Skip to content

Commit e21df2c

Browse files
committed
constants
1 parent ff14d01 commit e21df2c

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

packages/compass-aggregations/src/components/pipeline-toolbar/pipeline-options/pipeline-collation.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {
1414
import type { RootState } from '../../../modules';
1515
import { collationStringChanged } from '../../../modules/collation-string';
1616
import { maxTimeMSChanged } from '../../../modules/max-time-ms';
17-
import { DEFAULT_MAX_TIME_MS } from '../../../constants';
17+
import { DEFAULT_MAX_TIME_MS, WEB_MAX_TIME_MS_LIMIT } from '../../../constants';
1818
import { usePreference } from 'compass-preferences-model/provider';
1919

2020
const pipelineOptionsContainerStyles = css({
@@ -52,9 +52,6 @@ const collationInputId = 'aggregations-collation-toolbar-input';
5252
const maxTimeMSLabelId = 'aggregations-max-time-ms-toolbar-input-label';
5353
const maxTimeMSInputId = 'aggregations-max-time-ms-toolbar-input';
5454

55-
// Data Explorer limits (5 minutes = 300,000ms)
56-
const WEB_MAX_TIME_MS_LIMIT = 300_000; // 5 minutes
57-
5855
const PipelineCollation: React.FunctionComponent<PipelineCollationProps> = ({
5956
collationValue,
6057
collationHasError,

packages/compass-aggregations/src/constants.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
/**
2+
* Data Explorer limits (5 minutes = 300,000ms)
3+
* This limit is artificial but necessary for the backend that powers DE.
4+
* https://github.com/10gen/mms/blob/dea184f4a40db0a64ed0d6665d36265f62ae4f65/server/src/main/com/xgen/cloud/services/clusterconnection/runtime/ws/ClusterConnectionServerProvider.java#L50-L51
5+
*/
6+
export const WEB_MAX_TIME_MS_LIMIT = 300_000;
7+
18
/**
29
* Default for maxTimeMS option.
310
*/

packages/compass-query-bar/src/components/query-option.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ import {
1111
} from '@mongodb-js/compass-components';
1212
import { connect } from '../stores/context';
1313
import OptionEditor from './option-editor';
14-
import { OPTION_DEFINITION } from '../constants/query-option-definition';
14+
import {
15+
OPTION_DEFINITION,
16+
WEB_MAX_TIME_MS_LIMIT,
17+
} from '../constants/query-option-definition';
1518
import type {
1619
QueryOptionOfTypeDocument,
1720
QueryOption as QueryOptionType,
@@ -81,9 +84,6 @@ export const documentEditorLabelContainerStyles = css(
8184
}
8285
);
8386

84-
// Data Explorer limits for maxTimeMS (5 minutes = 300,000ms)
85-
const WEB_MAX_TIME_MS_LIMIT = 300_000; // 5 minutes
86-
8787
type QueryBarProperty = Exclude<QueryProperty, 'update'>;
8888

8989
type QueryOptionProps = {

0 commit comments

Comments
 (0)