From 76b02f8c0df31f7de58adbef0de9225621359740 Mon Sep 17 00:00:00 2001 From: mmeigs Date: Tue, 20 May 2025 14:23:24 -0400 Subject: [PATCH] ensure trailing slash on urls --- .../src/services/metadata/ToC/utils/convertSlugToUrl.ts | 2 +- .../persistence/tests/metadata/utils/convertSlugToUrl.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/persistence/src/services/metadata/ToC/utils/convertSlugToUrl.ts b/modules/persistence/src/services/metadata/ToC/utils/convertSlugToUrl.ts index 208093257..126728975 100644 --- a/modules/persistence/src/services/metadata/ToC/utils/convertSlugToUrl.ts +++ b/modules/persistence/src/services/metadata/ToC/utils/convertSlugToUrl.ts @@ -1,7 +1,7 @@ export const convertSlugToUrl = (slug, prefix, url, alias) => { const leading = ensureTrailingSlash(url) + prefix; const trailing = alias ? ensureLeadingSlash(alias) + ensureLeadingSlash(slug) : ensureLeadingSlash(slug); - return leading + trailing; + return ensureTrailingSlash(leading + trailing); }; const ensureTrailingSlash = (subpath: string) => { diff --git a/modules/persistence/tests/metadata/utils/convertSlugToUrl.test.ts b/modules/persistence/tests/metadata/utils/convertSlugToUrl.test.ts index 987b5b226..d56cc84a8 100644 --- a/modules/persistence/tests/metadata/utils/convertSlugToUrl.test.ts +++ b/modules/persistence/tests/metadata/utils/convertSlugToUrl.test.ts @@ -3,13 +3,13 @@ import { convertSlugToUrl } from '../../../src/services/metadata/ToC/utils/conve describe('convertSlugToUrl', () => { it("accepts a project's prefix, slug, alias and base url, and returns an absolute url for href usage", () => { expect(convertSlugToUrl('get-started', 'docs/atlas/cli', 'www.mongodb.com', 'current')).toEqual( - 'www.mongodb.com/docs/atlas/cli/current/get-started' + 'www.mongodb.com/docs/atlas/cli/current/get-started/' ); }); it('still returns a valid absolute url for href usage when alias is falsey', () => { expect(convertSlugToUrl('get-started', 'docs/charts', 'www.mongodb.com', '')).toEqual( - 'www.mongodb.com/docs/charts/get-started' + 'www.mongodb.com/docs/charts/get-started/' ); }); });