feat(popover): pass through popover enum types (#3302)

stephl3 · web-flow · commit c7d6e621b470 · 2025-11-14T15:14:00.000Z
* feat(combobox): export RenderMode enum from popover package

* chore(combobox): changeset

* feat(date-picker): export Align and Justify enums from popover package

* chore(date-picker): changeset

* feat(guide-cue): export BeaconAlign enum

* chore(guide-cue): changeset

* feat(menu): export Align, Justify, and RenderMode enums from popover package

* chore(menu): changeset

* feat(split-button): export RenderMode and make popover package dev dep

* chore(split-button): changeset

* refactor(split-button): consolidate menu imports

* refactor(split-button): rename imported enums
diff --git a/.changeset/bitter-carpets-obey.md b/.changeset/bitter-carpets-obey.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/guide-cue': minor
+---
+
+Export `BeaconAlign` enum
diff --git a/.changeset/full-ants-create.md b/.changeset/full-ants-create.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/split-button': minor
+---
+
+Export `RenderMode` enum
diff --git a/.changeset/loud-parts-flow.md b/.changeset/loud-parts-flow.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/combobox': minor
+---
+
+Export `RenderMode` enum
diff --git a/.changeset/public-readers-reply.md b/.changeset/public-readers-reply.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/date-picker': minor
+---
+
+Export `Align` and `Justify` enums
diff --git a/.changeset/yellow-carrots-say.md b/.changeset/yellow-carrots-say.md
@@ -0,0 +1,5 @@
+---
+'@leafygreen-ui/menu': minor
+---
+
+Export `Align`, `Justify`, and `RenderMode` enums
diff --git a/packages/combobox/src/Combobox/Combobox.types.ts b/packages/combobox/src/Combobox/Combobox.types.ts
@@ -2,7 +2,7 @@ import React, { ReactNode } from 'react';
 
 import { type ChipProps } from '@leafygreen-ui/chip';
 import { Either } from '@leafygreen-ui/lib';
-import { PopoverProps } from '@leafygreen-ui/popover';
+import { PopoverProps, RenderMode } from '@leafygreen-ui/popover';
 
 import {
   ComboboxSize,
@@ -14,6 +14,8 @@ import {
   State,
 } from '../types';
 
+export { RenderMode };
+
 /**
  * Combobox Props
  */
diff --git a/packages/combobox/src/Combobox/index.ts b/packages/combobox/src/Combobox/index.ts
@@ -3,4 +3,5 @@ export {
   type BaseComboboxProps,
   type ComboboxMultiselectProps,
   type ComboboxProps,
+  RenderMode,
 } from './Combobox.types';
diff --git a/packages/combobox/src/index.ts b/packages/combobox/src/index.ts
@@ -1,4 +1,4 @@
-export { Combobox, type ComboboxProps } from './Combobox';
+export { Combobox, type ComboboxProps, RenderMode } from './Combobox';
 export { ComboboxGroup, type ComboboxGroupProps } from './ComboboxGroup';
 export { ComboboxOption, type ComboboxOptionProps } from './ComboboxOption';
 export {
diff --git a/packages/date-picker/src/shared/types/BaseDatePickerProps.types.ts b/packages/date-picker/src/shared/types/BaseDatePickerProps.types.ts
@@ -1,11 +1,13 @@
 import { AriaLabelPropsWithLabel } from '@leafygreen-ui/a11y';
 import { LocaleString } from '@leafygreen-ui/date-utils';
 import { DarkModeProps } from '@leafygreen-ui/lib';
-import { PopoverProps } from '@leafygreen-ui/popover';
+import { Align, Justify, PopoverProps } from '@leafygreen-ui/popover';
 import { BaseFontSize, Size } from '@leafygreen-ui/tokens';
 
 import { AutoComplete, DatePickerState } from './types';
 
+export { Align, Justify };
+
 export type ModifiedPopoverProps = Omit<
   PopoverProps,
   | 'active'
diff --git a/packages/date-picker/src/shared/types/index.ts b/packages/date-picker/src/shared/types/index.ts
@@ -1,4 +1,8 @@
-export { type BaseDatePickerProps } from './BaseDatePickerProps.types';
+export {
+  Align,
+  type BaseDatePickerProps,
+  Justify,
+} from './BaseDatePickerProps.types';
 export {
   DateSegment,
   type DateSegmentsState,
diff --git a/packages/guide-cue/src/GuideCue/GuideCue.types.ts b/packages/guide-cue/src/GuideCue/GuideCue.types.ts
@@ -1,24 +1,10 @@
 import { DarkModeProps } from '@leafygreen-ui/lib';
-import { Align, Justify } from '@leafygreen-ui/popover';
-import { TooltipProps } from '@leafygreen-ui/tooltip';
-
-export const TooltipAlign = {
-  Top: Align.Top,
-  Bottom: Align.Bottom,
-  Left: Align.Left,
-  Right: Align.Right,
-} as const;
-
-export type TooltipAlign = (typeof TooltipAlign)[keyof typeof TooltipAlign];
-
-export const TooltipJustify = {
-  Start: Justify.Start,
-  Middle: Justify.Middle,
-  End: Justify.End,
-} as const;
-
-export type TooltipJustify =
-  (typeof TooltipJustify)[keyof typeof TooltipJustify];
+import { Align as BeaconAlign } from '@leafygreen-ui/popover';
+import {
+  Align as TooltipAlign,
+  Justify as TooltipJustify,
+  TooltipProps,
+} from '@leafygreen-ui/tooltip';
 
 // Exclude these from tooltip (tooltip already extends popover props)
 type ModifiedTooltipProps = Omit<
@@ -73,6 +59,8 @@ interface MultistepProps {
 
 type ConditionalProps = StandaloneProps | MultistepProps;
 
+export { BeaconAlign, TooltipAlign, TooltipJustify };
+
 export type GuideCueProps = ModifiedTooltipProps &
   ConditionalProps &
   DarkModeProps & {
@@ -138,5 +126,5 @@ export type GuideCueProps = ModifiedTooltipProps &
      * Determines the alignment of the beacon(animated pulsing circle that appears on top of the trigger element). This only applies to the multi-step tooltip.
      * @default 'center-horizontal'
      */
-    beaconAlign?: Align;
+    beaconAlign?: BeaconAlign;
   };
diff --git a/packages/guide-cue/src/GuideCue/index.ts b/packages/guide-cue/src/GuideCue/index.ts
@@ -1,5 +1,6 @@
 export { default } from './GuideCue';
 export {
+  BeaconAlign,
   type GuideCueProps,
   TooltipAlign,
   TooltipJustify,
diff --git a/packages/guide-cue/src/index.ts b/packages/guide-cue/src/index.ts
@@ -1,4 +1,5 @@
 export {
+  BeaconAlign,
   default as GuideCue,
   type GuideCueProps,
   TooltipAlign,
diff --git a/packages/menu/src/Menu/Menu.types.ts b/packages/menu/src/Menu/Menu.types.ts
@@ -5,10 +5,17 @@ import {
   InferredPolymorphicPropsWithRef,
   PolymorphicAs,
 } from '@leafygreen-ui/polymorphic';
-import { PopoverProps } from '@leafygreen-ui/popover';
+import {
+  Align,
+  Justify,
+  PopoverProps,
+  RenderMode,
+} from '@leafygreen-ui/popover';
 
 import { type SubMenuProps } from '../SubMenu/';
 
+export { Align, Justify, RenderMode };
+
 export type SubMenuType = ReactElement<
   InferredPolymorphicPropsWithRef<PolymorphicAs, SubMenuProps>
 >;
diff --git a/packages/menu/src/Menu/index.ts b/packages/menu/src/Menu/index.ts
@@ -1,2 +1,8 @@
 export { default as Menu } from './Menu';
-export { type MenuProps, MenuVariant } from './Menu.types';
+export {
+  Align,
+  Justify,
+  type MenuProps,
+  MenuVariant,
+  RenderMode,
+} from './Menu.types';
diff --git a/packages/menu/src/index.ts b/packages/menu/src/index.ts
@@ -1,5 +1,12 @@
 export { FocusableMenuItem } from './FocusableMenuItem';
-export { Menu, type MenuProps, MenuVariant } from './Menu';
+export {
+  Align,
+  Justify,
+  Menu,
+  type MenuProps,
+  MenuVariant,
+  RenderMode,
+} from './Menu';
 export {
   MenuContext,
   type MenuContextData,
diff --git a/packages/split-button/package.json b/packages/split-button/package.json
@@ -31,13 +31,13 @@
     "@leafygreen-ui/menu": "workspace:^",
     "@leafygreen-ui/palette": "workspace:^",
     "@leafygreen-ui/polymorphic": "workspace:^",
-    "@leafygreen-ui/popover": "workspace:^",
     "@leafygreen-ui/tokens": "workspace:^"
   },
   "peerDependencies": {
     "@leafygreen-ui/leafygreen-provider": "workspace:^5.0.0 || ^4.0.0 || ^3.2.0"
   },
   "devDependencies": {
+    "@leafygreen-ui/popover": "workspace:^",
     "@lg-tools/build": "workspace:^"
   },
   "exports": {
diff --git a/packages/split-button/src/SplitButton/SplitButton.spec.tsx b/packages/split-button/src/SplitButton/SplitButton.spec.tsx
@@ -11,11 +11,14 @@ import userEvent from '@testing-library/user-event';
 import { axe } from 'jest-axe';
 
 import { getLgIds as getMenuLgIds, MenuItem } from '@leafygreen-ui/menu';
-import { RenderMode } from '@leafygreen-ui/popover';
 
 import { getLgIds } from '../utils/getLgIds';
 
-import { MenuItemsType, SplitButtonProps } from './SplitButton.types';
+import {
+  MenuItemsType,
+  RenderMode,
+  SplitButtonProps,
+} from './SplitButton.types';
 import { SplitButton } from '.';
 
 const lgIds = getLgIds();
diff --git a/packages/split-button/src/SplitButton/SplitButton.tsx b/packages/split-button/src/SplitButton/SplitButton.tsx
@@ -10,7 +10,6 @@ import {
   InferredPolymorphic,
   useInferredPolymorphic,
 } from '@leafygreen-ui/polymorphic';
-import { RenderMode } from '@leafygreen-ui/popover';
 
 import { Menu } from '../Menu';
 import { getLgIds } from '../utils/getLgIds';
@@ -24,6 +23,7 @@ import {
   Align,
   InternalSplitButtonProps,
   Justify,
+  RenderMode,
   Variant,
 } from './SplitButton.types';
 
diff --git a/packages/split-button/src/SplitButton/SplitButton.types.ts b/packages/split-button/src/SplitButton/SplitButton.types.ts
@@ -6,17 +6,16 @@ import {
 } from '@leafygreen-ui/button';
 import { DarkModeProps } from '@leafygreen-ui/lib';
 import {
+  Align as MenuAlign,
+  Justify as MenuJustify,
   MenuItemProps,
   type MenuProps as ImportedMenuProps,
+  RenderMode,
 } from '@leafygreen-ui/menu';
 import {
   InferredPolymorphicProps,
   PolymorphicAs,
 } from '@leafygreen-ui/polymorphic';
-import {
-  Align as ImportedAlign,
-  Justify as ImportedJustify,
-} from '@leafygreen-ui/popover';
 
 export type MenuItemType = ReactElement<
   InferredPolymorphicProps<PolymorphicAs, MenuItemProps>
@@ -33,19 +32,21 @@ export const Variant = {
 export type Variant = (typeof Variant)[keyof typeof Variant];
 
 export const Align = {
-  Top: ImportedAlign.Top,
-  Bottom: ImportedAlign.Bottom,
+  Top: MenuAlign.Top,
+  Bottom: MenuAlign.Bottom,
 } as const;
 
 export type Align = (typeof Align)[keyof typeof Align];
 
 export const Justify = {
-  Start: ImportedJustify.Start,
-  End: ImportedJustify.End,
+  Start: MenuJustify.Start,
+  End: MenuJustify.End,
 } as const;
 
 export type Justify = (typeof Justify)[keyof typeof Justify];
 
+export { RenderMode };
+
 type ButtonProps = Omit<BaseButtonProps, 'rightGlyph' | 'variant'>;
 
 export type SelectedMenuProps = Pick<
diff --git a/packages/split-button/src/SplitButton/index.tsx b/packages/split-button/src/SplitButton/index.tsx
@@ -4,6 +4,7 @@ export {
   type InternalSplitButtonProps,
   Justify,
   type MenuItemType,
+  RenderMode,
   type SplitButtonProps,
   Variant,
 } from './SplitButton.types';
diff --git a/packages/split-button/src/index.ts b/packages/split-button/src/index.ts
@@ -2,6 +2,7 @@ export {
   Align,
   type InternalSplitButtonProps,
   Justify,
+  RenderMode,
   SplitButton,
   type SplitButtonProps,
   Variant,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@leafygreen-ui/guide-cue': minor
 +---
++
 +Export `BeaconAlign` enum
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-export { Combobox, type ComboboxProps } from './Combobox';`
	`1`	`+export { Combobox, type ComboboxProps, RenderMode } from './Combobox';`
`2`	`2`	`export { ComboboxGroup, type ComboboxGroupProps } from './ComboboxGroup';`
`3`	`3`	`export { ComboboxOption, type ComboboxOptionProps } from './ComboboxOption';`
`4`	`4`	`export {`