PYTHON-4332 create_search_index only sends "type" field when provided (#1573)

Author: ShaneHarvey

pymongo/operations.py

@@ -592,7 +592,7 @@ def __init__(
         self,
         definition: Mapping[str, Any],
         name: Optional[str] = None,
-        type: Optional[str] = "search",
+        type: Optional[str] = None,
         **kwargs: Any,
     ) -> None:
         """Create a Search Index instance.
@@ -613,7 +613,8 @@ def __init__(
         if name is not None:
             self.__document["name"] = name
         self.__document["definition"] = definition
-        self.__document["type"] = type
+        if type is not None:
+            self.__document["type"] = type
         self.__document.update(kwargs)
 
     @property

test/test_index_management.py

@@ -62,7 +62,17 @@ def test_inputs(self):
         listener.reset()
         with self.assertRaises(OperationFailure):
             coll.create_search_index({"definition": definition, "arbitraryOption": 1})
-        self.assertIn("arbitraryOption", listener.events[0].command["indexes"][0])
+        self.assertEqual(
+            {"definition": definition, "arbitraryOption": 1},
+            listener.events[0].command["indexes"][0],
+        )
+
+        listener.reset()
+        with self.assertRaises(OperationFailure):
+            coll.create_search_index({"definition": definition, "type": "search"})
+        self.assertEqual(
+            {"definition": definition, "type": "search"}, listener.events[0].command["indexes"][0]
+        )
 
 
 class SearchIndexIntegrationBase(unittest.TestCase):