not entirely sure why all this jruby contortions were happening?

Making everything work like MRI fixed a bunch of test failures...

Author: jamis

Rakefile

@@ -31,6 +31,7 @@ if jruby?
     ext.name = "native"
     ext.ext_dir = "src"
     ext.lib_dir = "lib/mongo/auth/kerberos"
+    ext.release = ENV['JAVA_RELEASE'].to_i if ENV['JAVA_RELEASE']
   end
 else
   require "rake/extensiontask"

lib/mongo/auth/kerberos/conversation.rb

@@ -127,25 +127,12 @@ def initialize(user, host)
 
         private
 
-        if BSON::Environment.jruby?
-
-          def start_token
-            BSON::Binary.new(authenticator.initialize_challenge)
-          end
-
-          def continue_token
-            payload = reply.documents[0][PAYLOAD]
-            BSON::Binary.new(authenticator.evaluate_challenge(payload.data))
-          end
-        else
-
-          def start_token
-            authenticator.initialize_challenge
-          end
+        def start_token
+          authenticator.initialize_challenge
+        end
 
-          def continue_token
-            authenticator.evaluate_challenge(reply.documents[0][PAYLOAD])
-          end
+        def continue_token
+          authenticator.evaluate_challenge(reply.documents[0][PAYLOAD])
         end
 
         def validate!(reply)

spec/mongo/auth/kerberos/conversation_spec.rb

@@ -57,13 +57,9 @@
       expect(selector[:mechanism]).to eq('GSSAPI')
     end
 
-    it 'sets the payload', unless: BSON::Environment.jruby? do
+    it 'sets the payload' do
       expect(selector[:payload]).to start_with('test')
     end
-
-    it 'sets the payload', if: BSON::Environment.jruby? do
-      expect(selector[:payload].data).to start_with('test')
-    end
   end
 
   describe '#finalize' do
@@ -72,8 +68,10 @@
       Mongo::Protocol::Reply.new
     end
 
+    let(:continue_token_contents) { 'testing' }
+
     let(:continue_token) do
-      BSON::Environment.jruby? ? BSON::Binary.new('testing') : 'testing'
+      continue_token_contents
     end
 
     context 'when the conversation is a success' do
@@ -82,7 +80,7 @@
         [{
           'conversationId' => 1,
           'done' => false,
-          'payload' => continue_token,
+          'payload' => continue_token_contents,
           'ok' => 1.0
         }]
       end
@@ -97,22 +95,18 @@
 
       before do
         expect(authenticator).to receive(:evaluate_challenge).
-          with('testing').and_return(continue_token)
+          with(continue_token_contents).and_return(continue_token_contents)
         reply.instance_variable_set(:@documents, documents)
       end
 
       it 'sets the conversation id' do
         expect(selector[:conversationId]).to eq(1)
       end
 
-      it 'sets the payload', unless: BSON::Environment.jruby? do
+      it 'sets the payload' do
         expect(selector[:payload]).to eq(continue_token)
       end
 
-      it 'sets the payload', if: BSON::Environment.jruby? do
-        expect(selector[:payload].data).to eq(continue_token)
-      end
-
       it 'sets the continue flag' do
         expect(selector[:saslContinue]).to eq(1)
       end