Revert introduction of forwardable (#107)

* Revert introduction of `forwardable`

Mongoid 7.1.0 introduced a regression (see
https://jira.mongodb.org/browse/MONGOID-4849) by switching to the
builtin ruby forwardable method of delegation rather than relying on the
ActiveSupport-provided delegation used before.

mongoid-locker was made compatible with the regressed version of mongoid
in mongodb/mongoid#4739

Mongoid then fixed this regression in 7.1.1+ with
mongodb/mongoid@d078acd,
which goes back to the active support way of delegating.

The `forwardable` inclusion in mongoid-locker causes incompatibilities
when you then include another gem that expects to be able to set up a
delegator within a mongoid document class. For example the
`mongoid-history` gem expects to be able to delegate using the
active-support style here:
https://github.com/mongoid/mongoid-history/blob/c8c4de1235c01252dfbdb9fe6c0abfc078ec1443/lib/mongoid/history/trackable.rb#L24-L25

This PR reverts the change to introduce `forwardable`.

See
mongoid/mongoid-history#238 (comment)
for an example of how this interacts poorly with mongoid-history.

* Add changelog entry, bump next to minor version

* Add an integration spec showing forwardable regression

Author: scpike

CHANGELOG.md

@@ -1,8 +1,9 @@
 ## Changelog
 
-### 2.1.1 (Next)
+### 2.2.0 (Next)
 
 * Your contribution here.
+* [#107](https://github.com/mongoid/mongoid-locker/pull/107): Revert introduction of `forwardable` to ensure compatibility with mongoid-history - [@scpike](https://github.com/scpike).
 
 ### 2.1.0 (2024-05-07)
 

Gemfile

@@ -29,6 +29,7 @@ group :development, :test do
 
   gem 'mongoid-compatibility'
   gem 'mongoid-danger', '~> 0.2.0'
+  gem 'mongoid-history'
   gem 'rspec', '~> 3.9'
   gem 'rubocop', '0.81.0'
   gem 'rubocop-rspec', '1.38.1'

lib/mongoid/locker.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require 'forwardable'
 require 'securerandom'
 
 module Mongoid
@@ -104,8 +103,6 @@ def reset!
 
       # @api private
       def included(klass)
-        klass.extend(Forwardable) unless klass.ancestors.include?(Forwardable)
-
         klass.extend ClassMethods
         klass.singleton_class.instance_eval { attr_accessor(*MODULE_METHODS) }
 
@@ -117,7 +114,7 @@ def included(klass)
         klass.backoff_algorithm = backoff_algorithm
         klass.locking_name_generator = locking_name_generator
 
-        klass.def_delegators(klass, *MODULE_METHODS)
+        klass.delegate(*MODULE_METHODS, to: :class)
         klass.singleton_class.delegate(*(methods(false) - MODULE_METHODS.flat_map { |method| [method, "#{method}=".to_sym] } - %i[included reset! configure]), to: self)
       end
     end

lib/mongoid/locker/version.rb

@@ -2,6 +2,6 @@
 
 module Mongoid
   module Locker
-    VERSION = '2.1.1'
+    VERSION = '2.2.0'
   end
 end

spec/integration/mongoid-history/mongoid_history_spec.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'mongoid-history'
+
+# This replicates the exception reported at https://github.com/mongoid/mongoid-history/issues/238#issuecomment-1063155193
+# when mongoid-locker required 'forwardable' instead of relying on the
+# active support-provided delegation method
+RSpec.describe 'MongoidHistory' do # rubocop:disable RSpec/DescribeClass
+  # rubocop:disable RSpec/ExampleLength
+  it 'does not raise an exception' do
+    expect do
+      Class.new do
+        include Mongoid::Document
+        include Mongoid::Locker
+        include Mongoid::History::Trackable
+
+        field :title
+
+        track_history on: [:title]
+      end
+    end.not_to raise_exception
+  end
+  # rubocop:enable RSpec/ExampleLength
+end

spec/spec_helper.rb

@@ -2,6 +2,8 @@
 
 ENV['RACK_ENV'] = 'test'
 
+require 'logger' # Required for compatibility with activesupport 7
+
 if ENV['COVERAGE']
   require 'simplecov'
   require 'simplecov_json_formatter'