Restore children param in image filter C API, keep STArray

Children parameter is passed through to the builder for future use
with static shader/blender/colorfilter children alongside image
filter inputs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: mattleibow

include/c/sk_runtimeeffect.h

@@ -19,8 +19,8 @@ SK_C_API void sk_runtimeeffect_unref(sk_runtimeeffect_t* effect);
 SK_C_API sk_shader_t* sk_runtimeeffect_make_shader(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount, const sk_matrix_t* localMatrix);
 SK_C_API sk_colorfilter_t* sk_runtimeeffect_make_color_filter(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount);
 SK_C_API sk_blender_t* sk_runtimeeffect_make_blender(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount);
-SK_C_API sk_imagefilter_t* sk_runtimeeffect_make_image_filter(sk_runtimeeffect_t* effect, sk_data_t* uniforms, const char* childShaderName, const sk_imagefilter_t* input);
-SK_C_API sk_imagefilter_t* sk_runtimeeffect_make_image_filter_with_children(sk_runtimeeffect_t* effect, sk_data_t* uniforms, float maxSampleRadius, const char** childShaderNames, const sk_imagefilter_t** inputs, int inputCount);
+SK_C_API sk_imagefilter_t* sk_runtimeeffect_make_image_filter(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount, const char* childShaderName, const sk_imagefilter_t* input);
+SK_C_API sk_imagefilter_t* sk_runtimeeffect_make_image_filter_with_children(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount, float maxSampleRadius, const char** childShaderNames, const sk_imagefilter_t** inputs, int inputCount);
 SK_C_API size_t sk_runtimeeffect_get_uniform_byte_size(const sk_runtimeeffect_t* effect);
 
 SK_C_API size_t sk_runtimeeffect_get_uniforms_size(const sk_runtimeeffect_t* effect);

src/c/sk_runtimeeffect.cpp

@@ -18,8 +18,6 @@
 
 #include "src/c/sk_types_priv.h"
 
-using namespace skia_private;
-
 sk_runtimeeffect_t* sk_runtimeeffect_make_for_color_filter(sk_string_t* sksl, sk_string_t* error) {
     auto [effect, errorMessage] = SkRuntimeEffect::MakeForColorFilter(AsString(*sksl));
     if (error && errorMessage.size() > 0)
@@ -135,18 +133,28 @@ void sk_runtimeeffect_get_child_from_name(const sk_runtimeeffect_t* effect, cons
     *cchild = *ToRuntimeEffectChild(AsRuntimeEffect(effect)->findChild(std::string_view(name, len)));
 }
 
-sk_imagefilter_t* sk_runtimeeffect_make_image_filter(sk_runtimeeffect_t* effect, sk_data_t* uniforms, const char* childShaderName, const sk_imagefilter_t* input) {
+sk_imagefilter_t* sk_runtimeeffect_make_image_filter(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount, const char* childShaderName, const sk_imagefilter_t* input) {
     SkRuntimeShaderBuilder builder(sk_ref_sp(AsRuntimeEffect(effect)), sk_ref_sp(AsData(uniforms)));
 
+    auto effectChildren = AsRuntimeEffect(effect)->children();
+    for (size_t i = 0; i < childCount && i < effectChildren.size(); i++) {
+        builder.child(effectChildren[i].name) = sk_ref_sp(AsFlattenable(children[i]));
+    }
+
     std::string_view name = childShaderName ? std::string_view(childShaderName) : std::string_view();
     return ToImageFilter(SkImageFilters::RuntimeShader(builder, name, sk_ref_sp(AsImageFilter(input))).release());
 }
 
-sk_imagefilter_t* sk_runtimeeffect_make_image_filter_with_children(sk_runtimeeffect_t* effect, sk_data_t* uniforms, float maxSampleRadius, const char** childShaderNames, const sk_imagefilter_t** inputs, int inputCount) {
+sk_imagefilter_t* sk_runtimeeffect_make_image_filter_with_children(sk_runtimeeffect_t* effect, sk_data_t* uniforms, sk_flattenable_t** children, size_t childCount, float maxSampleRadius, const char** childShaderNames, const sk_imagefilter_t** inputs, int inputCount) {
     SkRuntimeShaderBuilder builder(sk_ref_sp(AsRuntimeEffect(effect)), sk_ref_sp(AsData(uniforms)));
 
-    STArray<4, std::string_view> names(inputCount);
-    STArray<4, sk_sp<SkImageFilter>> skInputs(inputCount);
+    auto effectChildren = AsRuntimeEffect(effect)->children();
+    for (size_t i = 0; i < childCount && i < effectChildren.size(); i++) {
+        builder.child(effectChildren[i].name) = sk_ref_sp(AsFlattenable(children[i]));
+    }
+
+    skia_private::STArray<4, std::string_view> names(inputCount);
+    skia_private::STArray<4, sk_sp<SkImageFilter>> skInputs(inputCount);
     for (int i = 0; i < inputCount; i++) {
         names.push_back(std::string_view(childShaderNames[i]));
         skInputs.push_back(sk_ref_sp(AsImageFilter(inputs[i])));