Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit dc735d7

Browse files
committedJul 30, 2022
Use string.Contains(char) instead of (string)
CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1847
1 parent e674c3a commit dc735d7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎src/TaglibSharp/Picture.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ public Picture (File.IFileAbstraction abstraction)
365365
Filename = abstraction.Name;
366366
Description = abstraction.Name;
367367

368-
if (!string.IsNullOrEmpty (Filename) && Filename.Contains (".")) {
368+
if (!string.IsNullOrEmpty (Filename) && Filename.Contains ('.')) {
369369
MimeType = GetMimeFromExtension (Filename);
370370
Type = MimeType.StartsWith ("image/") ? PictureType.FrontCover : PictureType.NotAPicture;
371371
} else {

‎src/TaglibSharp/PictureLazy.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ public PictureLazy (File.IFileAbstraction abstraction, long offset = 0, long siz
148148
filename = abstraction.Name;
149149
Description = abstraction.Name;
150150

151-
if (!string.IsNullOrEmpty (filename) && filename.Contains (".")) {
151+
if (!string.IsNullOrEmpty (filename) && filename.Contains ('.')) {
152152
mime_type = Picture.GetMimeFromExtension (filename);
153153
type = mime_type.StartsWith ("image/") ? PictureType.FrontCover : PictureType.NotAPicture;
154154
}

0 commit comments

Comments
 (0)
Please sign in to comment.