Merge pull request #4541 from alfonso-salces/MOBILE-4862

MOBILE-4862 opener.ts: Handle error when open file

Author: dpalou

src/core/features/native/constants.ts

@@ -0,0 +1,26 @@
+// (C) Copyright 2015 Moodle Pty Ltd.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+export const enum CoreNativeCordovaPluginResultStatus {
+    NO_RESULT,
+    OK,
+    CLASS_NOT_FOUND_EXCEPTION,
+    ILLEGAL_ACCESS_EXCEPTION,
+    INSTANTIATION_EXCEPTION,
+    MALFORMED_URL_EXCEPTION,
+    IO_EXCEPTION,
+    INVALID_ACTION,
+    JSON_EXCEPTION,
+    ERROR
+}

src/core/singletons/opener.ts

@@ -30,6 +30,7 @@ import { CoreConfig } from '@services/config';
 import { CoreEvents } from '@singletons/events';
 import { CoreColors } from './colors';
 import { CorePrompts } from '@services/overlays/prompts';
+import { CoreNativeCordovaPluginResultStatus } from '@features/native/constants';
 
 /**
  * Singleton with helper functions to handler open files and urls.
@@ -124,18 +125,27 @@ export class CoreOpener {
             // Error, use the original path.
         }
 
-        const openFile = async (path: string, mimetype?: string) => {
+        const openFile = async (path: string, mimetype?: string, hasFailed?: boolean) => {
             try {
                 if (CoreOpener.shouldOpenWithDialog(options)) {
                     await FileOpener.showOpenWithDialog(path, mimetype || '');
                 } else {
                     await FileOpener.open(path, mimetype || '');
                 }
             } catch (error) {
+                if (
+                    hasFailed ||
+                    error.status !== CoreNativeCordovaPluginResultStatus.ERROR ||
+                    error.message.includes('Activity not found')
+                ) {
+                    throw error;
+                }
+
                 // If the file contains the % character without encoding the open can fail. Try again encoding it.
                 const encodedPath = encodeURI(path);
+
                 if (path !== encodedPath) {
-                    return await openFile(encodedPath, mimetype);
+                    return await openFile(encodedPath, mimetype, true);
                 }
 
                 throw error;