Skip to content

Commit a410bcb

Browse files
committed
Fixes undefined variable $cm
Fixes test: core_calendar\container_test::test_delete_module_delete_events
1 parent 68adb39 commit a410bcb

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

lib.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,13 @@ function oublog_delete_instance($oublogid) {
164164
// instances
165165
$DB->delete_records('oublog_instances', array('oublogid'=>$oublog->id));
166166

167+
if (!$cm = get_coursemodule_from_instance('oublog', $oublog->id)) {
168+
throw new moodle_exception('invalidcoursemodule');
169+
}
170+
167171
// Fulltext search data
168172
require_once(dirname(__FILE__).'/locallib.php');
169173
if (oublog_search_installed()) {
170-
$moduleid=$DB->get_field('modules', 'id', array('name'=>'oublog'));
171-
$cm=$DB->get_record('course_modules', array('module'=>$moduleid, 'instance'=>$oublog->id));
172-
if (!$cm) {
173-
throw new moodle_exception('invalidcoursemodule');
174-
}
175174
local_ousearch_document::delete_module_instance_data($cm);
176175
}
177176

0 commit comments

Comments
 (0)