port trait implementation to impl

Author: Guest0x0

array/array.mbti

@@ -31,7 +31,6 @@ impl FixedArray {
   new[T](Int, () -> T) -> Self[T] //deprecated
   new_with_index[T](Int, (Int) -> T) -> Self[T] //deprecated
   op_add[T](Self[T], Self[T]) -> Self[T]
-  op_equal[T : Eq](Self[T], Self[T]) -> Bool
   rev[T](Self[T]) -> Self[T]
   rev_each[T](Self[T], (T) -> Unit) -> Unit
   rev_eachi[T](Self[T], (Int, T) -> Unit) -> Unit
@@ -46,6 +45,7 @@ impl FixedArray {
   starts_with[T : Eq](Self[T], Self[T]) -> Bool
   swap[T](Self[T], Int, Int) -> Unit
 }
+impl[T : Eq] Eq for FixedArray[T]
 impl[X : @quickcheck.Arbitrary] @quickcheck.Arbitrary for FixedArray[X]
 
 impl Array {

array/fixedarray.mbt

@@ -960,7 +960,7 @@ test "ends_with" {
 ///   inspect!(arr1 == arr3, content="false")
 /// }
 /// ```
-pub fn FixedArray::op_equal[T : Eq](
+pub impl[T : Eq] Eq for FixedArray[T] with op_equal(
   self : FixedArray[T],
   that : FixedArray[T]
 ) -> Bool {

buffer/buffer.mbt

@@ -190,7 +190,7 @@ pub fn new(size_hint~ : Int = 0) -> T {
 ///   )
 /// }
 /// ```
-pub fn write_string(self : T, value : String) -> Unit {
+pub impl Logger for T with write_string(self, value) {
   self.grow_if_necessary(self.len + value.length() * 2)
   self.data.blit_from_string(self.len, value, 0, value.length())
   self.len += value.length() * 2
@@ -614,7 +614,7 @@ pub fn write_bytesview(self : T, value : @bytes.View) -> Unit {
 ///   )
 /// }
 /// ```
-pub fn write_substring(
+pub impl Logger for Buffer with write_substring(
   self : T,
   value : String,
   start : Int,
@@ -646,7 +646,7 @@ pub fn write_substring(
 /// )
 /// }
 /// ```
-pub fn write_char(self : T, value : Char) -> Unit {
+pub impl Logger for Buffer with write_char(self : T, value : Char) -> Unit {
   self.grow_if_necessary(self.len + 4)
   let inc = self.data.set_utf16le_char(self.len, value)
   self.len += inc

buffer/buffer.mbti

@@ -19,7 +19,6 @@ impl T {
   write_byte(Self, Byte) -> Unit
   write_bytes(Self, Bytes) -> Unit
   write_bytesview(Self, @bytes.View) -> Unit
-  write_char(Self, Char) -> Unit
   write_double_be(Self, Double) -> Unit
   write_double_le(Self, Double) -> Unit
   write_float_be(Self, Float) -> Unit
@@ -30,14 +29,13 @@ impl T {
   write_int_le(Self, Int) -> Unit
   write_iter(Self, Iter[Byte]) -> Unit
   write_object(Self, &Show) -> Unit
-  write_string(Self, String) -> Unit
   write_sub_string(Self, String, Int, Int) -> Unit //deprecated
-  write_substring(Self, String, Int, Int) -> Unit
   write_uint64_be(Self, UInt64) -> Unit
   write_uint64_le(Self, UInt64) -> Unit
   write_uint_be(Self, UInt) -> Unit
   write_uint_le(Self, UInt) -> Unit
 }
+impl Logger for T
 impl Show for T
 
 // Type aliases

builtin/array.mbt

@@ -241,7 +241,7 @@ pub fn Array::op_set[T](self : Array[T], index : Int, value : T) -> Unit {
 ///   inspect!(arr1 == arr3, content="false")
 /// }
 /// ```
-pub fn Array::op_equal[T : Eq](self : Array[T], other : Array[T]) -> Bool {
+pub impl[T : Eq] Eq for Array[T] with op_equal(self, other) {
   let self_len = self.length()
   let other_len = other.length()
   guard self_len == other_len else { return false }
@@ -285,7 +285,7 @@ pub fn Array::op_equal[T : Eq](self : Array[T], other : Array[T]) -> Bool {
 ///   inspect!(arr1.compare(arr1), content="0") // arr1 = arr1
 /// }
 /// ```
-pub fn Array::compare[T : Compare](self : Array[T], other : Array[T]) -> Int {
+pub impl[T : Compare] Compare for Array[T] with compare(self, other) {
   let len_self = self.length()
   let len_other = other.length()
   let cmp = len_self.compare(len_other)
@@ -1753,6 +1753,6 @@ pub fn Array::iter2[A](self : Array[A]) -> Iter2[Int, A] {
 ///   inspect!(arr.is_empty(), content="true")
 /// }
 /// ```
-pub fn Array::default[T]() -> Array[T] {
+pub impl[T] Default for Array[T] with default() {
   []
 }

builtin/bigint_js.mbt

@@ -113,13 +113,23 @@ pub fn BigInt::to_octets(self : BigInt, length? : Int) -> Bytes {
 }
 
 ///|
-pub extern "js" fn BigInt::compare(self : BigInt, other : BigInt) -> Int =
+extern "js" fn BigInt::compare(self : BigInt, other : BigInt) -> Int =
   #|(x, y) => x < y ? -1 : x > y ? 1 : 0
 
 ///|
-pub extern "js" fn BigInt::op_equal(self : BigInt, other : BigInt) -> Bool =
+pub impl Compare for BigInt with compare(self, other) {
+  self.compare(other)
+}
+
+///|
+extern "js" fn BigInt::equal(self : BigInt, other : BigInt) -> Bool =
   #|(x, y) => x === y
 
+///|
+pub impl Eq for BigInt with op_equal(self, other) {
+  self.equal(other)
+}
+
 ///|
 pub extern "js" fn BigInt::from_int(x : Int) -> BigInt =
   #|(x) => BigInt(x)

builtin/bigint_nonjs.mbt

@@ -850,7 +850,7 @@ pub fn BigInt::is_zero(self : BigInt) -> Bool {
 ///   inspect!(a.compare(a), content="0") // 42 = 42
 /// }
 /// ```
-pub fn BigInt::compare(self : BigInt, other : BigInt) -> Int {
+pub impl Compare for BigInt with compare(self, other) {
   if self.sign != other.sign {
     return if self.sign == Positive { 1 } else { -1 }
   }
@@ -897,7 +897,7 @@ pub fn BigInt::compare(self : BigInt, other : BigInt) -> Int {
 ///   inspect!(a == c, content="false")
 /// }
 /// ```
-pub fn BigInt::op_equal(self : BigInt, other : BigInt) -> Bool {
+pub impl Eq for BigInt with op_equal(self, other) {
   if self.sign != other.sign || self.len != other.len {
     return false
   }