Merge pull request #9 from morganney/develop

test: increase coverage

Author: morganney

README.md

@@ -16,8 +16,6 @@ You must use the wrapper around [`debug`](https://www.npmjs.com/package/debug) n
 Do not:
 * Alias your `import` or `require` of `Debug`
 * Spread your `require` of `Debug` over more than one line
-* Wrap code with `debug();like(this);debug()` on the same line
-* Other crazy things
 
 Just make simple debug statements.
 
@@ -55,11 +53,11 @@ localStorage.debug = 'some:feature'
 localStorage.debug = '*'
 ```
 
-Now reload your browser. To turn off debug logging you can `localStorage.debug = false`.
+Now reload your browser. To turn off debugging you can `localStorage.debug = false`.
 
 ### Stripping
 
-To remove the logging and bundling of debug usage register this loader with webpack.
+To remove the logging and bundling of `debug` usage register this loader with webpack.
 
 ```js
 module: {

__tests__/integration.js

@@ -0,0 +1,57 @@
+import path from 'path'
+import { fileURLToPath } from 'url'
+
+import webpack from 'webpack'
+import { createFsFromVolume, Volume } from 'memfs'
+
+import { debugCode } from '../src/purge.js'
+
+const { dirname, resolve } = path
+const filename = fileURLToPath(import.meta.url)
+const directory = dirname(filename)
+const build = entry => {
+  const compiler = webpack({
+    context: directory,
+    entry: `./${entry}`,
+    output: {
+      path: resolve(directory),
+      filename: 'bundle.js'
+    },
+    module: {
+      rules: [
+        {
+          test: /\.js$/,
+          exclude: /node_modules/,
+          type: 'module',
+          loader: resolve(directory, '../src/loader.js')
+        }
+      ]
+    }
+  })
+
+  compiler.outputFileSystem.join = path.join.bind(path)
+  compiler.outputFileSystem = createFsFromVolume(new Volume())
+
+  return new Promise((resolve, reject) => {
+    compiler.run((err, stats) => {
+      if (err) {
+        return reject(err)
+      }
+
+      if (stats.hasErrors()) {
+        return reject(stats.toJson().errors)
+      }
+
+      return resolve(stats)
+    })
+  })
+}
+
+describe('loader', () => {
+  it('is used by webpack to remove debug code from source files', async () => {
+    const stats = await build('__fixtures__/file.js')
+    const output = stats.toJson({ source: true }).modules[0].source
+
+    expect(output).toEqual(expect.not.stringContaining(new RegExp(debugCode, 'g')))
+  })
+})

__tests__/loader.js

@@ -1,57 +1,36 @@
-import path from 'path'
-import { fileURLToPath } from 'url'
+import { jest } from '@jest/globals'
 
-import webpack from 'webpack'
-import { createFsFromVolume, Volume } from 'memfs'
+import { loader } from '../src/loader.js'
 
-import { debugCode } from '../src/purge.js'
-
-const { dirname, resolve } = path
-const filename = fileURLToPath(import.meta.url)
-const directory = dirname(filename)
-const build = entry => {
-  const compiler = webpack({
-    context: directory,
-    entry: `./${entry}`,
-    output: {
-      path: resolve(directory),
-      filename: 'bundle.js'
-    },
-    module: {
-      rules: [
-        {
-          test: /\.js$/,
-          exclude: /node_modules/,
-          type: 'module',
-          loader: resolve(directory, '../src/loader.js')
-        }
-      ]
-    }
-  })
-
-  compiler.outputFileSystem.join = path.join.bind(path)
-  compiler.outputFileSystem = createFsFromVolume(new Volume())
-
-  return new Promise((resolve, reject) => {
-    compiler.run((err, stats) => {
-      if (err) {
-        return reject(err)
-      }
-
-      if (stats.hasErrors()) {
-        return reject(stats.toJson().errors)
-      }
-
-      return resolve(stats)
+describe('loader', () => {
+  const getStub = () => ({
+    callback: jest.fn((err, purgedSrc) => {
+      return purgedSrc
     })
   })
-}
-
-describe('loader', () => {
-  it('is used by webpack to remove debug code from source files', async () => {
-    const stats = await build('__fixtures__/file.js')
-    const output = stats.toJson({ source: true }).modules[0].source
 
-    expect(output).toEqual(expect.not.stringContaining(new RegExp(debugCode, 'g')))
+  it('removes debug usage', () => {
+    const stub = getStub()
+    let src = 'import { Debug } from "webpack-strip-debug-loader"'
+
+    loader.call(stub, src)
+    expect(stub.callback).toHaveBeenLastCalledWith(null, '\n', undefined, undefined)
+
+    src = 'debug("something")'
+    loader.call(stub, src)
+    expect(stub.callback).toHaveBeenLastCalledWith(null, '\n', undefined, undefined)
+
+    src = `if (true) {
+      debug(String.prototype.includes('foo'))
+    }`
+    loader.call(stub, src)
+    expect(stub.callback).toHaveBeenLastCalledWith(
+      null,
+      `if (true) {
+
+    }`,
+      undefined,
+      undefined
+    )
   })
 })

jest.config.js

@@ -9,7 +9,7 @@ export default {
      * Has to wait for better ESM suport for webpack loaders
      * @see https://github.com/webpack/loader-runner/issues/61
      */
-    '!**/__tests__/loader.js',
+    '!**/__tests__/integration.js',
     '!**/__tests__/__fixtures__/*.js'
   ],
   transform: {}

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "webpack-strip-debug-loader",
-  "version": "1.3.2",
+  "version": "1.3.3",
   "description": "Strips debug imports, declarations and expressions from your webpack bundles",
   "main": "dist",
   "type": "module",

package.json

@@ -1,4 +1,4 @@
-import { purge } from './purge'
+import { purge } from './purge.js'
 
 const loader = function (source, map, meta) {
   this.callback(null, purge(source), map, meta)