-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle specifying domain name in settings page #30
Comments
I like the idea that the user can specify a custom URL if they want one, but I don't see any reason to delete an app that just uses the URL we generate |
@bharatagarwal do you mean that we specifically own Very interesting idea. |
Ahhh, I get it. That could be cool, although it would mean we'd be paying the hosting bill for their app. |
That's why I was saying just keeping it live for an hour or so. |
Changing the domain wouldn't move it off of our cluster though... for that they'd have to deploy our PaaS on their own server and then redeploy their app there, right? So we could have our own custom deployed version that tells people you can try it out for a demo, but your app will be gone after an hour. For permanent deploys, deploy the PaaS yourself. |
Is that last bit what you mean by "Otherwise, the user can specify their own domain, we give them the steps to do it, and then generate the necessary services for it"? I was picturing that deploying our PaaS is done via a CLI, is the idea here that you could do it from the web? |
I think you got it in the comment about permanent deploys. I guess where I was coming from was, that if you don't have a custom domain available to you, there. should be a way to deploy apps, which I was thinking for demonstration purposes we could deploy from I don't remember what I meant by the sentence you've highlighted :/ |
I was thinking about the settings page feature where users can change their domain and realized a couple of things:
i.e. App.prototype.url = () => {
return `${this.title}.${mothershipDomain}`;
} We'd need to find a way to get the |
Yea, you're right about that. I think this one won't make it into v1. It would be nice to give them the ability to change the url for a particular app, though (assuming they'd set up a DNS record for a new URL to point at the manager IP). In that case, we probably do want the URL in the database, because you can't necessarily compute it from anything else. This feature isn't critical if the PaaS is for internal apps, but consultancies using it to deploy small client apps would want to set a real domain name for deployed apps. |
Here's what I was thinking:
Maybe, we allow users to deploy an app to mothershipapp.io by default but will only be deployed for 1 hour.
Otherwise, the user can specify their own domain, we give them the steps to do it, and then generate the necessary services for it.
The text was updated successfully, but these errors were encountered: