diff --git a/.golangci.yml b/.golangci.yml index 3f2aea46..c6d4ef37 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -7,8 +7,6 @@ run: - ".*\\.gen\\.go" linters-settings: - golint: - min-confidence: 0 maligned: suggest-new: true goconst: @@ -40,14 +38,14 @@ linters: - gofmt - gofumpt - goimports - - golint + #- golint - gomnd - gomodguard - gosec - gosimple - govet - ineffassign - - interfacer + #- interfacer #- maligned - misspell - nakedret @@ -55,7 +53,8 @@ linters: - noctx - nolintlint - prealloc - - scopelint + - revive + - exportloopref - sqlclosecheck - staticcheck - structcheck diff --git a/internal/dvserver/server.go b/internal/dvserver/server.go index 38a9e78c..56fb3e40 100644 --- a/internal/dvserver/server.go +++ b/internal/dvserver/server.go @@ -218,7 +218,8 @@ func New(ctx context.Context, h *cayley.Handle, schema *schema.Config, opts Opts } svc.httpListenerAddr = listener.Addr().String() srv := http.Server{ - Handler: r, + ReadHeaderTimeout: 2 * time.Second, // nolint:gomnd + Handler: r, } svc.workers.Add(func() error { httpLogger.Debug("starting HTTP server", zap.String("bind", opts.HTTPBind)) diff --git a/internal/githubprovider/model.go b/internal/githubprovider/model.go index 814e96f2..6685d83d 100644 --- a/internal/githubprovider/model.go +++ b/internal/githubprovider/model.go @@ -91,7 +91,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error { // assignees for _, assignee := range input.Assignees { - assigneeRet, err := fromUser(batch, assignee) // nolint:typecheck // false-positive? + assigneeRet, err := fromUser(batch, assignee) if err != nil { return fmt.Errorf("from user: %w", err) } @@ -106,7 +106,7 @@ func fromIssue(batch *dvmodel.Batch, input *github.Issue) error { // labels for _, label := range input.Labels { - labelRet, err := fromLabel(batch, label) // nolint:typecheck // false-positive? + labelRet, err := fromLabel(batch, label) if err != nil { return fmt.Errorf("from label: %w", err) }