Merge pull request #35 from move-elevator/phpstan-7

build: update phpstan level to 7

Author: Konrad Michalik

composer.json

@@ -12,6 +12,7 @@
 	],
 	"require": {
 		"php": "^8.1",
+		"ext-libxml": "*",
 		"ext-mbstring": "*",
 		"ext-simplexml": "*",
 		"composer-plugin-api": "^1.0 || ^2.0",

composer.lock

@@ -1,5 +1,5 @@
 parameters:
-	level: 6
+	level: 7
 	paths:
 		- src
 		- tests/src

phpstan-baseline.neon

@@ -2,6 +2,7 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          displayDetailsOnTestsThatTriggerWarnings="true"
+         displayDetailsOnTestsThatTriggerNotices="true"
          bootstrap="vendor/autoload.php"
          colors="true"
 >

phpstan.neon

@@ -271,11 +271,14 @@ private function resolveValidators(
         $only = !empty($inputOnly) ? $inputOnly : $config->getOnly();
         $skip = !empty($inputSkip) ? $inputSkip : $config->getSkip();
 
-        return match (true) {
+        /** @var array<int, class-string<ValidatorInterface>> $result */
+        $result = match (true) {
             !empty($only) => $only,
-            !empty($skip) => array_diff(ValidatorRegistry::getAvailableValidators(), $skip),
+            !empty($skip) => array_values(array_diff(ValidatorRegistry::getAvailableValidators(), $skip)),
             default => ValidatorRegistry::getAvailableValidators(),
         };
+
+        return $result;
     }
 
     /**
@@ -291,6 +294,7 @@ private function validateClassInput(
         }
 
         $classNames = str_contains($className, ',') ? explode(',', $className) : [$className];
+        /** @var array<int, class-string> $classes */
         $classes = [];
 
         foreach ($classNames as $name) {
@@ -300,7 +304,9 @@ private function validateClassInput(
                 $type,
                 $name
             );
-            $classes[] = $name;
+            /** @var class-string $validatedName */
+            $validatedName = $name;
+            $classes[] = $validatedName;
         }
 
         return $classes;

phpunit.xml

@@ -53,7 +53,12 @@ public function readFromComposerJson(string $composerJsonPath): ?TranslationVali
             return null;
         }
 
-        $composerData = json_decode(file_get_contents($composerJsonPath), true, 512, JSON_THROW_ON_ERROR);
+        $content = file_get_contents($composerJsonPath);
+        if (false === $content) {
+            return null;
+        }
+
+        $composerData = json_decode($content, true, 512, JSON_THROW_ON_ERROR);
         if (!is_array($composerData)) {
             return null;
         }

src/Command/ValidateTranslationCommand.php

@@ -40,7 +40,7 @@ public function validate(array $data): void
      */
     private function loadSchema(): object
     {
-        if (!file_exists(self::SCHEMA_PATH)) {
+        if (!file_exists(self::SCHEMA_PATH) || !is_readable(self::SCHEMA_PATH) || !is_file(self::SCHEMA_PATH)) {
             throw new \RuntimeException('JSON Schema file not found: '.self::SCHEMA_PATH);
         }
 

src/Config/ConfigReader.php

@@ -35,8 +35,13 @@ public function collectFiles(
             }
 
             foreach (ParserRegistry::getAvailableParsers() as $parserClass) {
+                $globFiles = glob($path.'/*');
+                if (false === $globFiles) {
+                    continue;
+                }
+
                 $files = array_filter(
-                    glob($path.'/*'),
+                    $globFiles,
                     static fn ($file) => in_array(
                         pathinfo($file, PATHINFO_EXTENSION),
                         $parserClass::getSupportedFileExtensions(),

src/Config/SchemaValidator.php

@@ -9,7 +9,7 @@ class ParserCache
     /** @var array<string, ParserInterface> */
     private static array $cache = [];
 
-    public static function get(string $filePath, ?string $parserClass): ParserInterface|bool
+    public static function get(string $filePath, ?string $parserClass): ParserInterface|false
     {
         if (null === $parserClass) {
             return false;
@@ -18,7 +18,9 @@ public static function get(string $filePath, ?string $parserClass): ParserInterf
         $cacheKey = $filePath.'::'.$parserClass;
 
         if (!isset(self::$cache[$cacheKey])) {
-            self::$cache[$cacheKey] = new $parserClass($filePath);
+            /** @var ParserInterface $parser */
+            $parser = new $parserClass($filePath);
+            self::$cache[$cacheKey] = $parser;
         }
 
         return self::$cache[$cacheKey];