Merge pull request #50 from move-elevator/fix-key-naming-enum

fix: improve error handling in EncodingValidator and update expected_convention in tests

Author: Konrad Michalik

src/Validator/EncodingValidator.php

@@ -41,6 +41,14 @@ public function processFile(ParserInterface $file): array
         $filePath = $file->getFilePath();
         $issues = [];
 
+        if (!file_exists($filePath)) {
+            $this->logger?->error(
+                'File does not exist: '.$file->getFileName(),
+            );
+
+            return [];
+        }
+
         // Read raw file content
         $content = file_get_contents($filePath);
         if (false === $content) {

src/Validator/KeyNamingConventionValidator.php

@@ -70,7 +70,7 @@ public function processFile(ParserInterface $file): array
                     $issueData[] = [
                         'key' => $key,
                         'file' => $file->getFileName(),
-                        'expected_convention' => $this->convention,
+                        'expected_convention' => $this->convention->value ?? 'custom pattern',
                         'pattern' => $this->getActivePattern(),
                         'suggestion' => $this->suggestCorrection($key),
                     ];

tests/src/Validator/EncodingValidatorTest.php

@@ -329,7 +329,7 @@ public function testFileReadErrorHandling(): void
         $logger = $this->createMock(\Psr\Log\LoggerInterface::class);
         $logger->expects($this->once())
             ->method('error')
-            ->with('Could not read file content: temp-file.yaml');
+            ->with('File does not exist: temp-file.yaml');
 
         $validator = new EncodingValidator($logger);
         $issues = $validator->processFile($mockParser);

tests/src/Validator/KeyNamingConventionValidatorTest.php

@@ -588,8 +588,8 @@ public function testDotNotationValidation(): void
         // Should detect invalid_key as violation
         $this->assertCount(1, $result);
         $this->assertEquals('invalid_key', $result[0]['key']);
-        // expected_convention is now an enum, not a string
-        $this->assertInstanceOf(\MoveElevator\ComposerTranslationValidator\Enum\KeyNamingConvention::class, $result[0]['expected_convention']);
+        // expected_convention is now a string value from enum
+        $this->assertEquals('dot.notation', $result[0]['expected_convention']);
     }
 
     public function testDotNotationConversion(): void