fix: simplify getContentByKey method by removing unused attribute parameter

Author: konradmichalik

.php-cs-fixer.php

@@ -13,4 +13,5 @@
         '@PSR2' => true,
         '@Symfony' => true,
     ])
+    ->setUnsupportedPhpVersionAllowed(true)
     ->setFinder($finder);

composer.json

@@ -66,7 +66,7 @@
 		],
 		"fix:composer": "@composer normalize",
 		"fix:editorconfig": "@lint:editorconfig --fix",
-		"fix:php": "PHP_CS_FIXER_IGNORE_ENV=1 php-cs-fixer fix",
+		"fix:php": "php-cs-fixer fix",
 		"lint": [
 			"@lint:composer",
 			"@lint:editorconfig",

src/Parser/JsonParser.php

@@ -60,7 +60,7 @@ public function extractKeys(): ?array
         return $extract($this->json);
     }
 
-    public function getContentByKey(string $key, string $attribute = 'source'): ?string
+    public function getContentByKey(string $key): ?string
     {
         // Note: the $attribute parameter is required by ParserInterface
         // but is not used for JSON, since JSON has no source/target concept.

src/Parser/ParserInterface.php

@@ -18,7 +18,7 @@ public static function getSupportedFileExtensions(): array;
      */
     public function extractKeys(): ?array;
 
-    public function getContentByKey(string $key, string $attribute = 'source'): ?string;
+    public function getContentByKey(string $key): ?string;
 
     public function getFileName(): string;
 

src/Parser/PhpParser.php

@@ -54,7 +54,7 @@ public function extractKeys(): ?array
         return $extract($this->translations);
     }
 
-    public function getContentByKey(string $key, string $attribute = 'source'): ?string
+    public function getContentByKey(string $key): ?string
     {
         // Note: the $attribute parameter is required by ParserInterface
         // but is not used for PHP files, since PHP has no source/target concept.

src/Parser/XliffParser.php

@@ -45,16 +45,28 @@ public function extractKeys(): ?array
         return $keys;
     }
 
-    public function getContentByKey(string $key, string $attribute = 'source'): ?string
+    public function getContentByKey(string $key): ?string
     {
+        $attribute = $this->hasTargetLanguage() ? 'target' : 'source';
+
         foreach ($this->xml->file->body->{'trans-unit'} as $unit) {
             if ((string) $unit['id'] === $key) {
                 if ('' !== (string) $unit->{$attribute}) {
                     return (string) $unit->{$attribute};
                 }
 
-                if ('source' === $attribute) {
-                    return $this->getContentByKey($key, 'target');
+                if ('target' === $attribute && $this->hasTargetLanguage()) {
+                    $fallbackContent = (string) $unit->source;
+                    if ('' !== $fallbackContent) {
+                        return $fallbackContent;
+                    }
+                }
+
+                if ('source' === $attribute && !$this->hasTargetLanguage()) {
+                    $fallbackContent = (string) $unit->target;
+                    if ('' !== $fallbackContent) {
+                        return $fallbackContent;
+                    }
                 }
             }
         }
@@ -84,4 +96,9 @@ public function getLanguage(): string
 
         return $language;
     }
+
+    private function hasTargetLanguage(): bool
+    {
+        return !empty((string) $this->xml->file['target-language']);
+    }
 }

src/Parser/YamlParser.php

@@ -52,7 +52,7 @@ public function extractKeys(): ?array
         return $extract($this->yaml);
     }
 
-    public function getContentByKey(string $key, string $attribute = 'source'): ?string
+    public function getContentByKey(string $key): ?string
     {
         // Note: the $attribute parameter is required by ParserInterface
         // but is not used for YAML, since YAML has no source/target concept.

tests/src/Fixtures/translations/xliff/fail/de.locallang.xlf

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
 <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
-    <file source-language="en" datatype="plaintext" original="messages">
+    <file target-language="de" source-language="en" datatype="plaintext" original="messages">
         <header/>
         <body>
             <trans-unit id="key1">

tests/src/Fixtures/translations/xliff/fail/de.locallang_be.xlf

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8" standalone="yes" ?>
 <xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
-    <file source-language="en" datatype="plaintext" original="messages">
+    <file target-language="de" source-language="en" datatype="plaintext" original="messages">
         <header/>
         <body>
             <trans-unit id="key1">

tests/src/Fixtures/translations/xliff/success/de.locallang.xlf

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
 <xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
-    <file source-language="en" datatype="plaintext" original="messages">
+    <file target-language="de" source-language="en" datatype="plaintext" original="messages">
         <header/>
         <body>
             <trans-unit id="key1">