test: add unit tests for configuration file reading and validation

Author: konradmichalik

phpunit.xml

@@ -3,6 +3,7 @@
          xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
          displayDetailsOnTestsThatTriggerWarnings="true"
          displayDetailsOnTestsThatTriggerNotices="true"
+         displayDetailsOnSkippedTests="true"
          bootstrap="vendor/autoload.php"
          colors="true"
 >

tests/src/Config/ConfigFileReaderTest.php

@@ -189,4 +189,61 @@ public function testReadPhpFileWithInvalidReturn(): void
 
         $this->reader->readAsConfig($configPath);
     }
+
+    public function testReadPhpConfigWithInvalidPath(): void
+    {
+        // We need to test readAsConfig() directly for PHP files to reach the realpath() check
+        $configPath = $this->tempDir.'/config.php';
+        $brokenLink = $this->tempDir.'/broken_link.php';
+
+        file_put_contents($configPath, '<?php return "test";');
+        symlink($configPath, $brokenLink);
+        unlink($configPath); // Break the symlink
+
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('Invalid configuration file path');
+
+        $this->reader->readAsConfig($brokenLink);
+    }
+
+    public function testReadJsonConfigWithNonArrayContent(): void
+    {
+        $configPath = $this->tempDir.'/config.json';
+        file_put_contents($configPath, '"string-content"');
+
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('Invalid JSON configuration file');
+
+        $this->reader->readFile($configPath);
+    }
+
+    public function testReadYamlConfigWithNonArrayContent(): void
+    {
+        $configPath = $this->tempDir.'/config.yaml';
+        file_put_contents($configPath, '"string-content"');
+
+        $this->expectException(\RuntimeException::class);
+        $this->expectExceptionMessage('Invalid YAML configuration file');
+
+        $this->reader->readFile($configPath);
+    }
+
+    public function testReadAsConfigUsesDirectPhpConfigPath(): void
+    {
+        // Test that readAsConfig() uses the direct PHP config path
+        $configPath = $this->tempDir.'/config.php';
+        $phpContent = '<?php
+use MoveElevator\ComposerTranslationValidator\Config\TranslationValidatorConfig;
+
+$config = new TranslationValidatorConfig();
+$config->setPaths([\'direct-php-test\']);
+return $config;
+';
+
+        file_put_contents($configPath, $phpContent);
+
+        $config = $this->reader->readAsConfig($configPath);
+
+        $this->assertSame(['direct-php-test'], $config->getPaths());
+    }
 }

tests/src/FileDetector/CollectorTest.php

@@ -356,4 +356,64 @@ public function testRecursiveCollectionUsesRealFixtures(): void
         // Should find files at multiple levels
         $this->assertNotEmpty($result);
     }
+
+    public function testCollectFilesWithoutDetector(): void
+    {
+        // Test fallback to FileDetectorRegistry when no detector is provided
+        file_put_contents($this->tempDir.'/test.xlf', 'xliff content');
+
+        $logger = $this->createMock(LoggerInterface::class);
+        $collector = new Collector($logger);
+
+        // Test without providing a detector (should use registry)
+        $result = $collector->collectFiles([$this->tempDir], null, null, false);
+
+        // Should use FileDetectorRegistry and find files
+        $this->assertNotEmpty($result);
+    }
+
+    public function testCollectFilesWithFileDetectorReturningEmptyResults(): void
+    {
+        // Create a file that exists but won't be detected by any file detector
+        file_put_contents($this->tempDir.'/test.xlf', 'xliff content');
+
+        $logger = $this->createMock(LoggerInterface::class);
+
+        // Mock a detector that returns empty results
+        $detector = $this->createMock(DetectorInterface::class);
+        $detector->method('mapTranslationSet')->willReturn([]);
+
+        $collector = new Collector($logger);
+
+        $result = $collector->collectFiles([$this->tempDir], $detector, null, false);
+
+        // When detector returns empty results, the result structure will include
+        // the parser class with the empty translation set
+        $this->assertNotEmpty($result);
+
+        // Check that the translation set is empty
+        $xliffParserClass = XliffParser::class;
+        $this->assertArrayHasKey($xliffParserClass, $result);
+        $this->assertArrayHasKey($this->tempDir, $result[$xliffParserClass]);
+        $this->assertEmpty($result[$xliffParserClass][$this->tempDir]);
+    }
+
+    public function testCollectFilesLogsDebugWhenNoFilesFoundForParser(): void
+    {
+        // Create directory with files that don't match any parser extensions
+        file_put_contents($this->tempDir.'/readme.txt', 'content');
+        file_put_contents($this->tempDir.'/data.csv', 'content');
+
+        $logger = $this->createMock(LoggerInterface::class);
+        $logger->expects($this->exactly(4)) // One for each parser class
+            ->method('debug')
+            ->with($this->stringContains('No files found for parser class'));
+
+        $detector = $this->createMock(DetectorInterface::class);
+        $collector = new Collector($logger);
+
+        $result = $collector->collectFiles([$this->tempDir], $detector, null);
+
+        $this->assertEmpty($result);
+    }
 }

tests/src/Validator/AbstractValidatorTest.php

@@ -317,4 +317,42 @@ public function testValidateCallsResetStateBeforeProcessing(): void
         $this->assertSame('some_file.xlf', $issues[0]->getFile());
         $this->assertSame(['validationIssue'], $issues[0]->getDetails());
     }
+
+    public function testValidateLogsDebugForUnsupportedParser(): void
+    {
+        $loggerMock = $this->createMock(LoggerInterface::class);
+        $loggerMock->expects($this->atLeastOnce())
+            ->method('debug')
+            ->with($this->logicalOr(
+                $this->stringContains('is not supported by the validator'),
+                $this->stringContains('UnsupportedValidator')
+            ));
+
+        // Create a custom validator that doesn't support TestParser
+        $validator = new class($loggerMock) extends AbstractValidator implements ValidatorInterface {
+            public function processFile(ParserInterface $file): array
+            {
+                return [];
+            }
+
+            public function supportsParser(): array
+            {
+                return []; // Empty - doesn't support any parser
+            }
+
+            public function postProcess(): void
+            {
+            }
+
+            public function getShortName(): string
+            {
+                return 'UnsupportedValidator';
+            }
+        };
+
+        $files = ['/path/to/test.xlf'];
+        $result = $validator->validate($files, TestParser::class);
+
+        $this->assertEmpty($result);
+    }
 }