-
Notifications
You must be signed in to change notification settings - Fork 185
Update AGP to 9.0.0-beta03 #3988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks great, thanks for getting it figured out! Just documenting here what we discussed on Slack that we probably want to manually specify the Kotlin version still rather than relying on whatever one AGP happens to want to use. Looks like a pretty easy thing to add: |
- Update `android-gradle-plugin` version in version catalog. - Remove `kotlin-android` plugin alias from version catalog and root build file. - Migrate `android.applicationVariants.configureEach` logic in `app/build.gradle` to `androidComponents` API (`beforeVariants` and `onVariants`) to support AGP 9.0. - Use `variant.buildConfigFields.put` instead of `buildConfigField`. - Update version code generation logic to use `variant.outputs` within `onVariants`. - Remove `variantFilter` block in favor of `beforeVariants` disabling. - Migrate `kotlinOptions.allWarningsAsErrors` to `tasks.withType(KotlinCompile).compilerOptions`.
Merge Queue Status
🚫 The pull request has left the queue (rule: This pull request spent 12 minutes 57 seconds in the queue, with no time running CI. Required conditions to merge
ReasonPull request #3988 has been dequeued by a HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
@mergify dequeue |
✅ The pull request has been removed from the queue |
|
@jonalmeida Something is very broken with mergify. I'm actually not opposed to this landing when CI is green, but it should probably get an r+ first at least 😆 |
|
Let me take a look! |
rvandermeulen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is still in Beta, it's getting pretty close to a stable release and I think it'd be beneficial for us to start getting some exposure to AGP 9.0 now to aid in the eventual Firefox transition down the road. I'd vote in favor of landing this but will defer to @jonalmeida to make the final call.
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
My changes to Github configuration did not work and this merged while I was in a meeting. 🤦 |
android-gradle-pluginversion in version catalog.kotlin-androidplugin alias from version catalog and root build file.android.applicationVariants.configureEachlogic inapp/build.gradletoandroidComponentsAPI (beforeVariantsandonVariants) to support AGP 9.0.variant.buildConfigFields.putinstead ofbuildConfigField.variant.outputswithinonVariants.variantFilterblock in favor ofbeforeVariantsdisabling.kotlinOptions.allWarningsAsErrorstotasks.withType(KotlinCompile).compilerOptions.Pull Request checklist