Skip to content

Commit bb088d2

Browse files
committed
adjust cot logging for less verbosity and more clarity
We can likely make more improvements here, but this is a start.
1 parent 369424a commit bb088d2

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

src/scriptworker/cot/verify.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1274,9 +1274,6 @@ async def populate_jsone_context(chain, parent_link, decision_link, tasks_for):
12741274
'Unknown cot_product_type "{}" for cot_product "{}"!'.format(chain.context.config["cot_product_type"], chain.context.config["cot_product"])
12751275
)
12761276

1277-
log.debug("{} json-e context:".format(parent_link.name))
1278-
# format_json() breaks on lambda values; use pprint.pformat here.
1279-
log.debug(pprint.pformat(jsone_context))
12801277
return jsone_context
12811278

12821279

@@ -1820,7 +1817,6 @@ def get_source_url(obj):
18201817
"""
18211818
source_env_prefix = obj.context.config["source_env_prefix"]
18221819
task = obj.task
1823-
log.debug("Getting source url for {} {}...".format(obj.name, obj.task_id))
18241820
repo = get_repo(obj.task, source_env_prefix=source_env_prefix)
18251821
source = task["metadata"]["source"]
18261822
if repo and not verify_repo_matches_url(repo, source):
@@ -1944,7 +1940,7 @@ async def verify_chain_of_trust(chain, *, check_task=False):
19441940
raise
19451941
else:
19461942
raise CoTError(str(exc))
1947-
log.info("Good.")
1943+
log.info("taskId %s passes chain of trust verification.", chain.task_id)
19481944

19491945

19501946
# verify_cot_cmdln {{{1
@@ -1970,10 +1966,6 @@ async def _async_verify_cot_cmdln(opts, tmp):
19701966
context.config["github_oauth_token"] = os.environ.get("SCRIPTWORKER_GITHUB_OAUTH_TOKEN")
19711967
cot = ChainOfTrust(context, opts.task_type, task_id=opts.task_id)
19721968
await verify_chain_of_trust(cot, check_task=True)
1973-
log.info(format_json(cot.dependent_task_ids()))
1974-
log.info("{} : {}".format(cot.name, cot.task_id))
1975-
for link in cot.links:
1976-
log.info("{} : {}".format(link.name, link.task_id))
19771969

19781970

19791971
def verify_cot_cmdln(args=None, event_loop=None):

src/scriptworker/utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,6 @@ async def download_file(context, url, abs_filename, session=None, chunk_size=128
666666
if not chunk:
667667
break
668668
fd.write(chunk)
669-
log.info("Done")
670669

671670

672671
# get_loggable_url {{{1

0 commit comments

Comments
 (0)