Skip to content

Commit 0233d37

Browse files
Bump express from 4.21.2 to 5.1.0 (#13518)
* Bump express from 4.21.2 to 5.1.0 Bumps [express](https://github.com/expressjs/express) from 4.21.2 to 5.1.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.21.2...v5.1.0) --- updated-dependencies: - dependency-name: express dependency-version: 5.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update test --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mathieu Pillard <[email protected]>
1 parent 44f9759 commit 0233d37

File tree

3 files changed

+204
-179
lines changed

3 files changed

+204
-179
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
"deep-eql": "4.1.3",
189189
"deepcopy": "2.1.0",
190190
"dompurify": "3.2.6",
191-
"express": "4.21.2",
191+
"express": "5.1.0",
192192
"express-http-context": "1.2.4",
193193
"filesize": "11.0.2",
194194
"focus-visible": "5.2.1",

tests/unit/amo/server/test_base.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -611,13 +611,15 @@ describe(__filename, () => {
611611

612612
expect(response.statusCode).toEqual(200);
613613
const [auth_cookie, session_cookie] = response.headers['set-cookie'];
614-
expect(auth_cookie).toContain(
615-
`${defaultConfig.get('cookieName')}=; Max-Age=0;`,
616-
);
614+
expect(auth_cookie).toContain(`${defaultConfig.get('cookieName')}=;`);
615+
expect(auth_cookie).toContain('Expires=Thu, 01 Jan 1970 00:00:00 GMT;');
617616
expect(auth_cookie).toContain('Domain=.addons.mozilla.org;');
618617
expect(auth_cookie).toContain('Path=/;');
619618
expect(auth_cookie).toContain('HttpOnly; Secure; SameSite=Lax');
620-
expect(session_cookie).toContain(`sessionid=; Max-Age=0;`);
619+
expect(session_cookie).toContain(`sessionid=;`);
620+
expect(session_cookie).toContain(
621+
'Expires=Thu, 01 Jan 1970 00:00:00 GMT;',
622+
);
621623
expect(session_cookie).toContain('Domain=.addons.mozilla.org;');
622624
expect(session_cookie).toContain('Path=/;');
623625
expect(session_cookie).toContain('HttpOnly; Secure; SameSite=Lax');

0 commit comments

Comments
 (0)