Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Healthcheck should notify of recovery #15451

Open
1 task
KevinMind opened this issue Mar 14, 2025 · 3 comments
Open
1 task

[Task]: Healthcheck should notify of recovery #15451

KevinMind opened this issue Mar 14, 2025 · 3 comments
Labels
repository:addons-server Issue relating to addons-server

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Mar 14, 2025

Description

As of #15440 the healtcheck slack notification is only when there are failures.

When the healthcheck workflow runs, if the previous run was a failure and the current run was a success, we should get a notification that the issue is resolved.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@KevinMind KevinMind added needs:info repository:addons-server Issue relating to addons-server labels Mar 14, 2025
@diox
Copy link
Member

diox commented Mar 25, 2025

Note: We now have a dummy monitor that depends on a waffle switch to play with

@diox
Copy link
Member

diox commented Mar 25, 2025

With the way things are implemented right now, the recovery is easier to implement by just running the healthcheck more often (like once per hour) so that we don't have to bother with recording state.

@diox
Copy link
Member

diox commented Mar 25, 2025

We are putting this on the back burner until other notifications-related bits are done. Ultimately both failures and recoveries should not be that frequent...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

3 participants