[Bug]: sync_promoted_addons integrity error when promoted approval has no application_id

[KevinMind]

What happened?

when running sync_promoted_addons we attempt to create PromotedAddonVersion instances from existing PromotedApproval instances.. however this causes db errors when the approval has no application_id as the version requires it.

What did you expect to happen?

we should skip no application_d approvals as "non-approved" should equate to non-existent in the new model

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[ioanarusiczki]

• I tried some new recommended add-ons for All Application or for a particular platform and then checked admin, frontend and rev tools pages, looked as expected.
• I tried changing a promotion from recommended to by firefox -> once the promotion type is changed the frontend badge would no longer be displayed and after new version is approved it would get the new badge -> I remember this was the behavior so again no problems here
• looking over older promotions [Bug]: [DEV] "Recommended" and "By Firefox" badge does not appear on addon detail page #15487 is fixed