Skip to content

[Bug]: "has_requested_review" is accepting other values than boolean True #16062

@ioanarusiczki

Description

@ioanarusiczki

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

A version is content rejected from rev tools.
A developer is sending a PATCH request requesting a new review such as https://addons-dev.allizom.org/api/v5/addons/addon/640694/listingcontentreview/

with the "has_requested_review" as form-data set or as a JSON {"has_requested_review":"esfgbrrtntyn"}, {"has_requested_review":" "}

What did you expect to happen?

The API response is returning has_requested_review: true.

In this case it should only accept the boolean True/False, throw an error otherwise.

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions