Commit 44091d9
committed
fix(DENG-11237): drop schema.yaml + destination_table:null for GCS export
The prior fix used scheduling.destination_table: null, but that field with a
query.py trips DAG task validation (task.py: destination_table None and
query_file_path None -> 'One of destination_table or query_file_path must be
specified'); the only existing destination_table:null tasks are query.sql.
Use the reviewer's primary suggestion instead: ship only metadata.yaml +
query.py (no schema.yaml), matching the newtab_merino GCS-export tasks. On the
current deploy code a missing schema is a non-fatal SkippedDeployException
(dry-run path) / _resolve_isolated_schema is skipped when there's no manifest,
so no empty table is created and stage-deploy doesn't fail. CSV column contract
stays documented in metadata.yaml.1 parent eb3dc5e commit 44091d9
2 files changed
Lines changed: 3 additions & 25 deletions
File tree
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
17 | 16 | | |
18 | 17 | | |
19 | 18 | | |
| |||
26 | 25 | | |
27 | 26 | | |
28 | 27 | | |
29 | | - | |
30 | 28 | | |
31 | 29 | | |
32 | 30 | | |
| |||
Lines changed: 0 additions & 20 deletions
This file was deleted.
0 commit comments