feat: tweak http response error handling

Author: kik-kik

sql/moz-fx-data-shared-prod/google_play_store_derived/slow_startup_events_by_startup_type_and_version_v1/query.py

@@ -84,11 +84,10 @@ def get_slow_start_rates_by_app_and_date_and_version(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()
 

sql/moz-fx-data-shared-prod/google_play_store_derived/slow_startup_events_by_startup_type_v1/query.py

@@ -83,11 +83,10 @@ def get_slow_start_rates_by_app_and_date(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()
 

sql/moz-fx-data-shared-prod/google_play_store_derived/slow_startup_events_by_startup_type_version_and_device_v1/query.py

@@ -35,7 +35,7 @@ def create_request_payload_using_logical_dag_date(date_to_pull_data_for):
     date_to_pull_data_for_month = date_to_pull_data_for.month
     date_to_pull_data_for_day = date_to_pull_data_for.day
 
-    end_date = date_to_pull_data_for
+    end_date = date_to_pull_data_for + timedelta(days=1)
 
     day_after_date_to_pull_data_for_yr = end_date.year
     day_after_date_to_pull_data_for_month = end_date.month
@@ -89,11 +89,10 @@ def get_slow_start_rates_by_app_and_date(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()
 
@@ -112,8 +111,7 @@ def main():
     logical_dag_date_string = logical_dag_date.strftime("%Y-%m-%d")
     print("logical_dag_date_string: ", logical_dag_date_string)
 
-    # Get 2 days prior - we always will pull data for the previous day
-    data_pull_date = logical_dag_date - timedelta(days=1)
+    data_pull_date = logical_dag_date
     data_pull_date_string = data_pull_date.strftime("%Y-%m-%d")
     print("data_pull_date")
     print(data_pull_date)

sql/moz-fx-data-shared-prod/google_play_store_derived/vitals_anr_rate_v1/query.py

@@ -157,11 +157,10 @@ def fetch_data(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()
 

sql/moz-fx-data-shared-prod/google_play_store_derived/vitals_crash_rate_v1/query.py

@@ -156,11 +156,10 @@ def fetch_data(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()
 

sql/moz-fx-data-shared-prod/google_play_store_derived/vitals_error_count_v1/query.py

@@ -144,11 +144,10 @@ def fetch_data(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()
 

sql/moz-fx-data-shared-prod/google_play_store_derived/vitals_lmk_rate_v1/query.py

@@ -155,11 +155,10 @@ def fetch_data(
 
     try:
         response.raise_for_status()
-    except requests.exceptions.HTTPError:
-        error_message = f"Request to: {response.url} failed with the following error: {response.json()}"
-        print(error_message)
-
-        raise requests.exceptions.HTTPError(error_message) from None
+    except requests.exceptions.HTTPError as err:
+        raise requests.exceptions.HTTPError(
+            f"Request to: {response.url} failed with status {response.status_code}: {response.text}"
+        ) from err
 
     return response.json()