Enforce a max header size of 998 characters in emails #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbudhram
approved these changes
Mar 4, 2020
| @@ -28,6 +28,8 @@ use hyperx::{ | |||
| header::{parsing::from_one_raw_str, Formatter, Raw as RawHeader}, | |||
| }; | |||
|
|
|||
| const HEADER_MAX_LENGTH: usize = 998; | |||
There was a problem hiding this comment.
I think a comment here would be helpful for future us on why this exists.
dannycoates
reviewed
Mar 4, 2020
| fn any_header_length() { | ||
| let mut rng = rand::thread_rng(); | ||
|
|
||
| let header = Link::new(std::iter::repeat("X").take(rng.gen_range(0, 2000)).collect::<String>().to_owned()); |
There was a problem hiding this comment.
idk that this needs to be a random length string, just one over the max.
jodyheavener
force-pushed
the
jh/4390-truncate-headers
branch
2 times, most recently
from
101d4d2 to
06ce6e5
Compare
…2 recommendation RFC 5322 2.1.1 - https://tools.ietf.org/html/rfc5322#section-2.1.1 This is an attempt tp address Bugzilla #1618831
jodyheavener
force-pushed
the
jh/4390-truncate-headers
branch
from
06ce6e5 to
08cb9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4390
Enforces a maximum header size of 998 characters per RFC 5322 recommendation. This is a hopeful solution to a failed mail delivery noted in Bugzilla 1618831.
Note this is 998 characters total (key + value).