Skip to content

Commit 8bf3ea8

Browse files
committed
Bug 1908788 - Ensure we build geckodriver for host platform, r=webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D217953
1 parent 18ee1f2 commit 8bf3ea8

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

testing/geckodriver/doc/Building.md

+12-3
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,23 @@ the WebDriver protocol. geckodriver translates WebDriver [commands],
77
[responses], and [errors] to the [Marionette protocol], and acts
88
as a proxy between [WebDriver] and [Marionette].
99

10-
To build geckodriver:
10+
To build geckodriver as part of a source Firefox build, add the
11+
following to `mozconfig`:
12+
13+
```shell
14+
ac_add_options --enable-geckodriver
15+
```
16+
17+
With this addition geckodriver will be built when Firefox is built. It
18+
can also be built alone by passing in the source path to the `mach
19+
build` command:
1120

1221
```shell
1322
% ./mach build testing/geckodriver
1423
```
1524

16-
If you use artifact builds you may build geckodriver using cargo,
17-
since mach in this case does not have a compile environment:
25+
Artifact builds don't download geckodriver by default, but it can be
26+
built using cargo:
1827

1928
```shell
2029
% cd testing/geckodriver

testing/geckodriver/moz.build

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# License, v. 2.0. If a copy of the MPL was not distributed with this
33
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
44

5-
RUST_PROGRAMS += ["geckodriver"]
5+
HOST_RUST_PROGRAMS += ["geckodriver"]
66
# Some Rust build scripts compile C/C++ sources, don't error on warnings for them.
77
AllowCompilerWarnings()
88

0 commit comments

Comments
 (0)