Bug 1499453 - Use GeckoResult.ALLOW/DENY shortcuts in GeckoView code r=android-reviewers,owlish,tchoh

Differential Revision: https://phabricator.services.mozilla.com/D208415

Author: Gela

mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngineSession.kt

@@ -1158,9 +1158,9 @@ class GeckoEngineSession(
 
             return when {
                 maybeInterceptRequest(request, false) != null ->
-                    GeckoResult.fromValue(AllowOrDeny.DENY)
+                    GeckoResult.deny()
                 request.target == NavigationDelegate.TARGET_WINDOW_NEW ->
-                    GeckoResult.fromValue(AllowOrDeny.ALLOW)
+                    GeckoResult.allow()
                 else -> {
                     notifyObservers {
                         onLoadRequest(
@@ -1170,7 +1170,7 @@ class GeckoEngineSession(
                         )
                     }
 
-                    GeckoResult.fromValue(AllowOrDeny.ALLOW)
+                    GeckoResult.allow()
                 }
             }
         }
@@ -1180,15 +1180,15 @@ class GeckoEngineSession(
             request: NavigationDelegate.LoadRequest,
         ): GeckoResult<AllowOrDeny> {
             if (request.target == NavigationDelegate.TARGET_WINDOW_NEW) {
-                return GeckoResult.fromValue(AllowOrDeny.ALLOW)
+                return GeckoResult.allow()
             }
 
             return if (maybeInterceptRequest(request, true) != null) {
-                GeckoResult.fromValue(AllowOrDeny.DENY)
+                GeckoResult.deny()
             } else {
                 // Not notifying session observer because of performance concern and currently there
                 // is no use case.
-                GeckoResult.fromValue(AllowOrDeny.ALLOW)
+                GeckoResult.allow()
             }
         }
 

mobile/android/android-components/components/browser/engine-gecko/src/test/java/mozilla/components/browser/engine/gecko/GeckoEngineSessionTest.kt

@@ -4361,7 +4361,7 @@ class GeckoEngineSessionTest {
             mockLoadRequest("sample:about", triggeredByRedirect = true),
         )
 
-        assertEquals(geckoResult!!, GeckoResult.fromValue(AllowOrDeny.ALLOW))
+        assertEquals(geckoResult!!, GeckoResult.allow())
     }
 
     @Test

mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebExtensionController.java

@@ -1549,7 +1549,7 @@ void newTab(final Message message, final WebExtension extension) {
     if (delegate != null) {
       result = delegate.onCloseTab(extension, message.session);
     } else {
-      result = GeckoResult.fromValue(AllowOrDeny.DENY);
+      result = GeckoResult.deny();
     }
 
     message.callback.resolveTo(

mobile/android/test_runner/src/main/java/org/mozilla/geckoview/test_runner/TestRunnerActivity.java

@@ -174,7 +174,7 @@ public void onLocationChange(
         public GeckoResult<AllowOrDeny> onLoadRequest(
             final GeckoSession session, final LoadRequest request) {
           // Allow Gecko to load all URIs
-          return GeckoResult.fromValue(AllowOrDeny.ALLOW);
+          return GeckoResult.allow();
         }
 
         @Override
@@ -296,7 +296,7 @@ public void onPageAction(
         public GeckoResult<AllowOrDeny> onCloseTab(
             @Nullable final WebExtension source, @NonNull final GeckoSession session) {
           closeSession(session);
-          return GeckoResult.fromValue(AllowOrDeny.ALLOW);
+          return GeckoResult.allow();
         }
 
         @Override
@@ -310,7 +310,7 @@ public GeckoResult<AllowOrDeny> onUpdateTab(
             mOwnedSessions.addFirst(session);
           }
 
-          return GeckoResult.fromValue(AllowOrDeny.ALLOW);
+          return GeckoResult.allow();
         }
       };