Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation tab language #5

Open
r-win opened this issue Nov 13, 2012 · 3 comments
Open

Presentation tab language #5

r-win opened this issue Nov 13, 2012 · 3 comments
Assignees
Milestone

Comments

@r-win
Copy link

r-win commented Nov 13, 2012

When changing the language on the presentation tab, you'll have to reload the tab before the new selected language is used. I think it should auto reload the tab, or show a message that you need to reload.

But what's more funny, is that the name of the classes used for the table in that same tab is also translated. The dutch word for Photo is Foto, and the id of the PresentationPhoto table is also changed to PresentationFoto. Because there is no CSS class for that, it's going to look ugly ;)

File affected: https://github.com/mpemberton5/Web-UI-for-Serviio/blob/master/view/presentation.php#L12.
Maybe make the styles fixed instead of dynamic?

@mpemberton5
Copy link
Owner

Two excellent thoughts. I had thought about the auto-refresh, but never implemented it. Also a great idea on static names. Never crossed my mind about those being translated.

Cheers!

@ghost ghost assigned mpemberton5 Nov 13, 2012
@mpemberton5
Copy link
Owner

Got the auto-refresh added to the 1.3 release.

Going to take another iteration on the best way to solve the CSS issue. The way it's coded now is to take whatever Serviio sends me for the names, which is where Foto is probably coming from. It'll take some reworking of that whole tab which I'll do in the next release.

@r-win
Copy link
Author

r-win commented Dec 18, 2012

Just curious, but can't you use the $id instead? That is the same in all languages, as far as I know. I for images, V for video and P for photos (or something like that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants