Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable to external requests creating UDP amplification #1

Open
Phenomite opened this issue Dec 22, 2018 · 1 comment
Open

Vulnerable to external requests creating UDP amplification #1

Phenomite opened this issue Dec 22, 2018 · 1 comment

Comments

@Phenomite
Copy link

Requests from external internet sources can trigger large amplification factors using simple payloads such as ":" or "tds:GetServices/", causing almost 100x in amplification.

Please address this in future, some recommendations.

  • Add a rate limit
  • Limit "Fault" messages to a smaller size
  • Disable external internet access by default and when this is intended as an internal network discovery protocol
  • Switch to TCP

Thanks.

@mpromonet
Copy link
Owner

mpromonet commented Dec 22, 2018

Hi Phenomite,

This project was just an experimentation, I did not work on it since years.
Feel free to submit improvement using pull request.

Best Regards,
Michel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants