Skip to content

Commit 0952edc

Browse files
committed
refactor: source dialog sizes from MpvqcConstants
Dialog content width and height were spread across the base dialog and several concrete dialogs as repeated magic numbers, leaving the existing MpvqcConstants sizing values as the intended-but-unused source of truth. Point the dialogs at those shared constants so sizing lives in one place and stays consistent, and so the previously orphaned smallDialogContentWidth constant is actually used.
1 parent 80b0d9f commit 0952edc

7 files changed

Lines changed: 12 additions & 7 deletions

File tree

qt/qml/io/github/mpvqc/mpvQC/Components/MpvqcDialog.qml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,16 @@ pragma ComponentBehavior: Bound
77
import QtQuick
88
import QtQuick.Controls.Material
99

10+
import io.github.mpvqc.mpvQC.Utility
11+
1012
Dialog {
1113
id: root
1214

1315
readonly property bool isMirrored: Application.layoutDirection === Qt.RightToLeft
1416

1517
popupType: Qt.platform.os === "windows" ? Popup.Window : Popup.Item
1618
anchors.centerIn: Overlay.overlay
17-
contentWidth: 370
19+
contentWidth: MpvqcConstants.smallDialogContentWidth
1820
modal: true
1921
dim: false
2022
z: 2

qt/qml/io/github/mpvqc/mpvQC/Dialogs/CommentTypes/MpvqcCommentTypesDialog.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,15 @@ import QtQuick.Layouts
1010

1111
import io.github.mpvqc.mpvQC.Components
1212
import io.github.mpvqc.mpvQC.Python
13+
import io.github.mpvqc.mpvQC.Utility
1314

1415
MpvqcDialog {
1516
id: root
1617
objectName: "commentTypesDialog"
1718

1819
readonly property MpvqcCommentTypesDialogViewModel viewModel: MpvqcCommentTypesDialogViewModel {}
1920

20-
contentHeight: 450
21+
contentHeight: MpvqcConstants.smallDialogContentHeight
2122

2223
title: qsTranslate("CommentTypesDialog", "Comment Types")
2324
standardButtons: Dialog.Ok | Dialog.Cancel | Dialog.Reset

qt/qml/io/github/mpvqc/mpvQC/Dialogs/MpvqcAppearanceDialog.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ MpvqcDialog {
3636
readonly property int staggerInterval: 15
3737
}
3838

39-
contentHeight: 450
39+
contentHeight: MpvqcConstants.smallDialogContentHeight
4040

4141
title: qsTranslate("AppearanceDialog", "Appearance")
4242

qt/qml/io/github/mpvqc/mpvQC/Dialogs/MpvqcBackupDialog.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ MpvqcDialog {
2121
readonly property int minBackupInterval: 15
2222
readonly property int maxBackupInterval: 5 * 60
2323

24-
contentHeight: 450
24+
contentHeight: MpvqcConstants.smallDialogContentHeight
2525

2626
title: qsTranslate("BackupDialog", "Backup Settings")
2727

qt/qml/io/github/mpvqc/mpvQC/Dialogs/MpvqcExportSettingsDialog.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ import QtQuick.Layouts
77

88
import io.github.mpvqc.mpvQC.Components
99
import io.github.mpvqc.mpvQC.Python
10+
import io.github.mpvqc.mpvQC.Utility
1011

1112
MpvqcDialog {
1213
id: root
1314
objectName: "exportSettingsDialog"
1415

1516
readonly property MpvqcExportSettingsDialogViewModel viewModel: MpvqcExportSettingsDialogViewModel {}
1617

17-
contentHeight: 450
18+
contentHeight: MpvqcConstants.smallDialogContentHeight
1819

1920
title: qsTranslate("ExportSettingsDialog", "Export Settings")
2021

qt/qml/io/github/mpvqc/mpvQC/Dialogs/MpvqcImportSettingsDialog.qml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@ import QtQuick.Layouts
88

99
import io.github.mpvqc.mpvQC.Components
1010
import io.github.mpvqc.mpvQC.Python
11+
import io.github.mpvqc.mpvQC.Utility
1112

1213
MpvqcDialog {
1314
id: root
1415
objectName: "importSettingsDialog"
1516

1617
readonly property MpvqcImportSettingsDialogViewModel viewModel: MpvqcImportSettingsDialogViewModel {}
1718

18-
contentHeight: 450
19+
contentHeight: MpvqcConstants.smallDialogContentHeight
1920

2021
title: qsTranslate("ImportSettingsDialog", "Import Settings")
2122

qt/qml/io/github/mpvqc/mpvQC/Dialogs/MpvqcShortcutDialog.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ MpvqcDialog {
1919

2020
title: qsTranslate("ShortcutsDialog", "Keyboard Shortcuts")
2121

22-
contentWidth: 500
22+
contentWidth: MpvqcConstants.mediumDialogContentWidth
2323
contentHeight: Math.min(720, MpvqcWindowUtility.appHeight * 0.65)
2424

2525
contentItem: ColumnLayout {

0 commit comments

Comments
 (0)