fix(win): work around Popup.Window bugs in context menu

On Windows the footer context menu uses Popup.Window, which trips two
Qt bugs:

* The "Progress in percent" MenuItem auto-toggles a second time from a
  spurious release event delivered while the popup is closing, leaving
  `checked` out of sync with the view-model. Resync `checked` from the
  view-model on `aboutToShow` and `closed`; the inline binding is
  dropped since it gets broken by the first user toggle anyway.

* QTBUG-145585: Popup.Window ignores the `modal` property, so clicks
  pass through to widgets underneath. Add an overlay-level
  MpvqcFooterContextMenuClickGuard, modeled after the existing new-
  comment menu guard, that intercepts presses and closes the menu.

Popup.Item platforms are unaffected.

Author: trin94

pyproject.toml

@@ -284,6 +284,7 @@ files = [
     "qt/qml/utility/MpvqcWindowUtility.qml",
     "qt/qml/utility/qmldir",
     "qt/qml/views/footer/MpvqcFooterContextMenu.qml",
+    "qt/qml/views/footer/MpvqcFooterContextMenuClickGuard.qml",
     "qt/qml/views/footer/MpvqcFooterView.qml",
     "qt/qml/views/footer/qmldir",
     "qt/qml/views/footer/tst_MpvqcFooterView.qml",

qt/qml/views/footer/MpvqcFooterContextMenu.qml

@@ -75,12 +75,21 @@ MpvqcMenu {
     MenuSeparator {}
 
     MenuItem {
+        id: _percentMenuItem
         objectName: "percentMenuItem"
 
         text: qsTranslate("MainWindow", "Progress in percent")
-        checked: root.isPercentChecked
         checkable: true
 
         onTriggered: root.percentToggled()
     }
+
+    // Workaround for QTBUG-145585: on Windows the Popup.Window menu can
+    // deliver a spurious release event while closing, causing MenuItem to
+    // auto-toggle a second time and leaving `checked` out of sync with the
+    // view-model. Force-resync on both lifecycle edges:
+    //   - aboutToShow: pick up any external changes made while closed.
+    //   - closed:      undo the spurious toggle delivered during close.
+    onAboutToShow: _percentMenuItem.checked = root.isPercentChecked
+    onClosed: _percentMenuItem.checked = root.isPercentChecked
 }

qt/qml/views/footer/MpvqcFooterContextMenuClickGuard.qml

@@ -0,0 +1,55 @@
+// SPDX-FileCopyrightText: mpvQC developers
+//
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+// Workaround for QTBUG-145585: On Windows, Popup.Window menus do not respect
+// the modal property, allowing clicks to pass through to underlying items.
+// This item lives in the window overlay layer and intercepts every click
+// while the footer context menu is open, closing it and swallowing the event
+// so nothing underneath reacts.
+//
+// The _menuOpen flag is cleared via Qt.callLater instead of directly in
+// onClosed because the signal is delivered immediately; without the deferral
+// the overlay would be gone before the click arrives.
+//
+// TODO: Remove this file when Qt fixes QTBUG-145585.
+
+import QtQuick
+import QtQuick.Controls
+
+Item {
+    id: root
+
+    required property var menu
+
+    property bool _menuOpen: false
+
+    parent: Overlay.overlay
+    anchors.fill: parent
+    visible: Qt.platform.os === "windows" && _menuOpen && root.menu !== null
+
+    Connections {
+        target: root.menu
+
+        function onAboutToShow(): void {
+            root._menuOpen = true;
+        }
+
+        function onClosed(): void {
+            Qt.callLater(() => {
+                root._menuOpen = false;
+            });
+        }
+    }
+
+    MouseArea {
+        anchors.fill: parent
+        acceptedButtons: Qt.LeftButton
+
+        onPressed: event => {
+            event.accepted = true;
+            root._menuOpen = false;
+            root.menu.close();
+        }
+    }
+}

qt/qml/views/footer/MpvqcFooterView.qml

@@ -138,4 +138,8 @@ Item {
             onPercentToggled: root.viewModel.toggleStatusbarPercentage()
         }
     }
+
+    MpvqcFooterContextMenuClickGuard {
+        menu: _contextMenuLoader.item
+    }
 }

qt/qml/views/footer/qmldir

@@ -7,3 +7,4 @@ module views.footer
 MpvqcFooterView MpvqcFooterView.qml
 
 internal MpvqcFooterContextMenu MpvqcFooterContextMenu.qml
+internal MpvqcFooterContextMenuClickGuard MpvqcFooterContextMenuClickGuard.qml