Skip to content

Commit 7614688

Browse files
authored
Merge pull request #20 from msamsami/improve-contributing-page
📝 Add sections for installing `uv` and making contributions to the Contributing page
2 parents 9651361 + 0c7d521 commit 7614688

1 file changed

Lines changed: 44 additions & 12 deletions

File tree

docs/contributing.md

Lines changed: 44 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,33 @@
11
# Contributing
22

3+
We welcome contributions from the community to help improve FastAPI Maintenance.
4+
35
First, you might want to see the basic ways to [help FastAPI Maintenance package and get help](help.md).
46

57
## Developing
68

79
If you already cloned the <a href="https://github.com/msamsami/fastapi-maintenance" class="external-link" target="_blank">fastapi-maintenance repository</a> and you want to deep dive in the code, here are some guidelines to set up your environment.
810

9-
### Virtual Environment with `uv`
11+
### Install `uv`
12+
13+
We use `uv` for Python dependency management. If you don't have `uv` installed, follow the instructions on the <a href="https://docs.astral.sh/uv/guides/install-python" class="external-link" target="_blank">official uv website</a>.
14+
15+
Once `uv` is installed, navigate to the cloned repository.
16+
17+
### Set up Virtual Environment
1018

11-
We use `uv` for Python package management. To set up your development environment:
19+
To set up your development virtual environment with `uv`:
1220

13-
```console
21+
```bash
1422
uv venv
15-
source .venv/bin/activate # On Windows: .venv\Scripts\activate
23+
source .venv/bin/activate
1624
```
1725

18-
### Install Development Dependencies
26+
### Install Dependencies
1927

20-
After activating the environment, install the required development packages:
28+
After activating the environment, install the required package and development dependencies:
2129

22-
```console
30+
```bash
2331
uv sync --all-extras --all-groups
2432
```
2533

@@ -29,17 +37,15 @@ This installs all the dependencies in your environment.
2937

3038
There is a script that you can run that will format and clean all your code:
3139

32-
```console
40+
```bash
3341
bash scripts/format.sh
3442
```
3543

36-
It will also auto-sort all your imports.
37-
3844
## Tests
3945

4046
We use pytest for testing. To run the tests and generate coverage reports:
4147

42-
```console
48+
```bash
4349
bash scripts/test.sh
4450
```
4551

@@ -53,7 +59,7 @@ First, make sure you set up your environment as described above, that will insta
5359

5460
During local development, you can build the documentation site and check for any changes with live-reloading:
5561

56-
```console
62+
```bash
5763
mkdocs serve
5864
```
5965

@@ -68,3 +74,29 @@ The documentation uses <a href="https://www.mkdocs.org/" class="external-link" t
6874
All the documentation is in Markdown format in the directory `./docs`.
6975

7076
Many of the tutorials have blocks of code. In most cases, these blocks of code are actual complete applications that can be run as is.
77+
78+
## Making Contributions
79+
80+
### Coding Standards
81+
82+
We try to maintain high code quality standards to ensure consistency across the project:
83+
84+
- Follow PEP 8 guidelines.
85+
- Write meaningful tests for new features or bug fixes.
86+
87+
### Creating a Pull Request
88+
89+
After making your changes:
90+
91+
- Push your changes to your fork.
92+
- Open a pull request with a clear description of your changes.
93+
- Update the documentation if necessary.
94+
95+
### Code Reviews
96+
97+
Your contributions will go through our review process:
98+
99+
- Address any feedback from code reviews.
100+
- Once approved, your contributions will be merged into the main branch.
101+
102+
Thank you for contributing to FastAPI Maintenance 🚀

0 commit comments

Comments
 (0)