Blindly pass Plug.Conn.Adapter opts through

Author: mtrudel

lib/bandit/http2/adapter.ex

@@ -47,14 +47,12 @@ defmodule Bandit.HTTP2.Adapter do
   @impl Plug.Conn.Adapter
   def read_req_body(%__MODULE__{} = adapter, opts) do
     validate_calling_process!(adapter)
-    length = Keyword.get(opts, :length, 8_000_000)
-    timeout = Keyword.get(opts, :read_timeout, 15_000)
 
     metrics =
       adapter.metrics
       |> Map.put_new_lazy(:req_body_start_time, &Bandit.Telemetry.monotonic_time/0)
 
-    case Bandit.HTTP2.Stream.read_data(adapter.stream, length, timeout) do
+    case Bandit.HTTP2.Stream.read_data(adapter.stream, opts) do
       {:ok, body, stream} ->
         body = IO.iodata_to_binary(body)
 

lib/bandit/http2/stream.ex

@@ -242,7 +242,11 @@ defmodule Bandit.HTTP2.Stream do
     [{"cookie", combined_cookie} | other_headers]
   end
 
-  def read_data(stream, max_bytes, timeout), do: do_read_data(stream, max_bytes, timeout, [])
+  def read_data(stream, opts) do
+    max_bytes = Keyword.get(opts, :length, 8_000_000)
+    timeout = Keyword.get(opts, :read_timeout, 15_000)
+    do_read_data(stream, max_bytes, timeout, [])
+  end
 
   defp do_read_data(%__MODULE__{state: state} = stream, max_bytes, timeout, acc)
        when state in [:open, :local_closed] do

lib/bandit/http2/stream_process.ex

@@ -9,8 +9,6 @@ defmodule Bandit.HTTP2.StreamProcess do
 
   use GenServer, restart: :temporary
 
-  # A stream process can be created only once we have an adapter & set of headers. Pass them in
-  # at creation time to ensure this invariant
   @spec start_link(
           Bandit.HTTP2.Stream.t(),
           Bandit.Pipeline.plug_def(),