WSS broken by frame masking

[peaceful-james]

Maybe this is just happening for me. I am investigating.

[peaceful-james]

I confirm problem goes away when I run on commit cd855ec.

[mtrudel]

Thanks for the note. I'll back out that addition to give @alisinabh a chance to address it

[peaceful-james]

Thanks for the note. I'll back out that addition to give @alisinabh a chance to address it

Wait, I am blaming the wrong PR. It works fine on commit 898afdc.

[peaceful-james]

OK I confirm the problem is on commit f16b4c3 which is PR #421 which is yours @mtrudel

The call is coming from inside the house

[mtrudel]

Can you provide a repro?

[alisinabh]

I took a quick look and it seems like we responding with compression enabled (content-encoding: gzip) on websocket which is not supported for websocket (it is but permessage-deflate must be used).

Working version

Not working version

[mtrudel]

Got it! I backed that PR out of main/1.6.0 and re-released. I'll get this fixed directly.

Since this is no longer an issue on main I'll copy the relevant details from here over to #421 (which I'll also reopen).

Thanks for the quick bug @peaceful-james !

[peaceful-james]

OK that explains why my repro was not working. 😆 Thanks for the swift response!

[mtrudel]

All of the relevant fixes are in 1.6.1, just released. If you're able, I'd greatly appreciate confirmation that your concerns are still fixed in it!

[peaceful-james]

@mtrudel I used 1.6.1. No issues! 👍🏻 I confirm that my "concerns are still fixed in it".