Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status code no longer in telemetry for websocket upgrade requests #463

Open
binaryseed opened this issue Jan 31, 2025 · 0 comments
Open

Status code no longer in telemetry for websocket upgrade requests #463

binaryseed opened this issue Jan 31, 2025 · 0 comments

Comments

@binaryseed
Copy link

binaryseed commented Jan 31, 2025 •
edited
Loading

Since #428 was released to use inform instead of send_resp as part of the websocket upgrade request, the conn is no longer updated with status = 101, so when it is passed to telemetry handlers at the end of the span, we no longer have a status to report.

Is there a way we could still update the status field in the conn without interfering with subsequent behavior?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@binaryseed