-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Windows, screen reader reads lines out of turn #523
Comments
Line-endings? |
@tjguk that seems so simple and obvious it may just be the problem 😄 |
I had a quick try with SciTE to see if it was a Scintilla problem but I am not seeing the same error there. |
Nice idea. Unfortunately the QScintilla control we're using is a complete re-implementation of the Scintilla control, not merely a wrapper! |
Ah. back to the drawing board. I'd like to find out the minimal way of deciding if it's a bug with mu or QScintilla (or NVDA) |
If you haven't: could you try saving the file, please, and then trying again? Or: can you confirm whether the behaviour is at all different with:
The reason for these questions is that we have some slightly fiddly line-ending code going on when saving or opening and since this looks a bit like a line-ending issue I'd like to know if there's any likely interaction. |
It's not you. If I make a simple QScintilla editor in python using the example code here I get exactly the same bug. I'll work out where to submit that and post a link here. But to answer your question it fails on the first and second option, but not the third. I.e. new file = fail, new saved file = fail, file loaded from disk = no fail. |
Ah. Good catch, then. Hopefully it'll be something Nice and Easy [tm] for the PyQt guys and they'll be able to post an updated wheel Real Soon [tm] for us to update to. Thanks for working this through for us. |
I'm not entirely sure where to post QScintilla bug reports, so I've put it on their mailing list here: https://riverbankcomputing.com/pipermail/qscintilla/2018-July/001318.html |
I heard back from Phil Thompson at Riverbank Computing. He asked if I could try tonight's QScintilla snapshot. I don't think I am going to get time to attend to this soon, so if anyone has a working Mu build, NVDA, and access to the QScintilla snapshots please take a look. He suggested that the problem isrelatedto CR-LF line endings. and that if that is the case Mu could set the EOL mode to EOLUnix on all platforms. |
Cannot reproduce on current master and fresh installed NVDA. Also tried a simple QScintilla editor example, no mistakes. But if I press the right arrow at the end of a line, NVDA will read "carriage return" or "line feed". Not sure whether QScintilla changed, NVDA special-cases the previous issue, or my environment isn't representative of the ones where the problem shows up. |
This has been demonstrated on more than one screen reader. This doesn't appear to happen when the file that's being edited has been loaded from the file system. I.e. it only works with tabs that were originally created from new.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: