Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL text size - always start with default size #553

Closed
martinohanlon opened this issue Jul 13, 2018 · 9 comments
Closed

REPL text size - always start with default size #553

martinohanlon opened this issue Jul 13, 2018 · 9 comments

Comments

@martinohanlon
Copy link
Contributor

When you start the REPL it always starts up in the default text size, not the size of the text in the code window.

To replicate.

  • Open Mu
  • Close REPL (if its open)
  • Zoom in all the way on the code editor
  • Open the REPL
  • It will be at the default text size.

image

If you open the REPL before zooming in / out, the text in the REPL is sized correctly.

@ZanderBrown
Copy link
Contributor

We really need #530 to abstract panels

@carlosperate
Copy link
Member

carlosperate commented Jul 13, 2018

I think in this case we also need to abstract zoom level as well.
Clicking on the zoom buttons only affects the stuff that's open (so for instance if you open a new text tab it will start with the default zoom level), we need something to hold state and every feature that can change its zoom should be able to check what's the current global level.

@ntoll is this likely a candidate for "post-1.0"?

@ntoll
Copy link
Member

ntoll commented Jul 13, 2018

Given how zooming is implemented, it should be trivial to fix. Let me see how far I get today. ;-)

@ntoll
Copy link
Member

ntoll commented Jul 15, 2018

Hmm... OK, I've just looked into this. It's not so simple so I'll say this is a todo for 1.1 rather than a quick fix for 1.0 (out this week!). ;-)

@carlosperate carlosperate added this to the post-1.0 milestone Jul 15, 2018
@tjguk
Copy link
Collaborator

tjguk commented Jul 25, 2018

To confirm: is the general idea here to retain zoom level as state (ie in the session file) and to re-apply to all panels when restarted? Because I think that's probably what's wanted, ie if we have visually impaired users (or people with really good eyesight and long lines of code) they'll presumably want to always have very big (or very small) text.

@ZanderBrown
Copy link
Contributor

ZanderBrown commented Jul 25, 2018

Ideally we should try and restore panel states as well I think (perhaps not whether they are open but size and position) but #530 would help with that

@carlosperate
Copy link
Member

While I agree that zoom level saved in the settings file could be a good addition (I'm not totally convinced yet, as I like having a known state when opened, but the use case about impaired users is a very good one that's hard to argue against), I don't think it should be done with the panes as well. Having a default known state when they are opened can be useful for the classroom and to match any posible screenshots.

But I haven't given this much thought, so there could be a very good reason to do it.

@ntoll
Copy link
Member

ntoll commented Jul 27, 2018

FWIW +1 on zoom state, -0 on panel positions. Let's do zoom first and see if we get feedback.

@ntoll
Copy link
Member

ntoll commented Dec 18, 2018

Fixed by 5b82f22

@ntoll ntoll closed this as completed Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants