-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REPL text size - always start with default size #553
Comments
We really need #530 to abstract panels |
I think in this case we also need to abstract zoom level as well. @ntoll is this likely a candidate for "post-1.0"? |
Given how zooming is implemented, it should be trivial to fix. Let me see how far I get today. ;-) |
Hmm... OK, I've just looked into this. It's not so simple so I'll say this is a todo for 1.1 rather than a quick fix for 1.0 (out this week!). ;-) |
To confirm: is the general idea here to retain zoom level as state (ie in the session file) and to re-apply to all panels when restarted? Because I think that's probably what's wanted, ie if we have visually impaired users (or people with really good eyesight and long lines of code) they'll presumably want to always have very big (or very small) text. |
Ideally we should try and restore panel states as well I think (perhaps not whether they are open but size and position) but #530 would help with that |
While I agree that zoom level saved in the settings file could be a good addition (I'm not totally convinced yet, as I like having a known state when opened, but the use case about impaired users is a very good one that's hard to argue against), I don't think it should be done with the panes as well. Having a default known state when they are opened can be useful for the classroom and to match any posible screenshots. But I haven't given this much thought, so there could be a very good reason to do it. |
FWIW +1 on zoom state, -0 on panel positions. Let's do zoom first and see if we get feedback. |
Fixed by 5b82f22 |
When you start the REPL it always starts up in the default text size, not the size of the text in the code window.
To replicate.
If you open the REPL before zooming in / out, the text in the REPL is sized correctly.
The text was updated successfully, but these errors were encountered: