Skip to content

[all components][docs] Document missing transition data attributes#4098

Open
atomiks wants to merge 2 commits intomui:masterfrom
atomiks:codex/transition-status-data-attrs-docs
Open

[all components][docs] Document missing transition data attributes#4098
atomiks wants to merge 2 commits intomui:masterfrom
atomiks:codex/transition-status-data-attrs-docs

Conversation

@atomiks
Copy link
Contributor

@atomiks atomiks commented Feb 16, 2026

@atomiks atomiks added docs Improvements or additions to the documentation. scope: all components Widespread work has an impact on almost all components. labels Feb 16, 2026
@mui-bot
Copy link

mui-bot commented Feb 16, 2026

Bundle size report

Bundle Parsed size Gzip size
@base-ui/react 🔺+285B(+0.06%) 🔺+94B(+0.06%)

Details of bundle changes


Check out the code infra dashboard for more information about this PR.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 16, 2026

commit: c43a063

@netlify
Copy link

netlify bot commented Feb 16, 2026

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 21b248c
🔍 Latest deploy log https://app.netlify.com/projects/base-ui/deploys/6992ebb1db85fa00084257b8
😎 Deploy Preview https://deploy-preview-4098--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@atomiks atomiks marked this pull request as ready for review February 16, 2026 01:59
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 16, 2026

Greptile Summary

This PR documents previously missing transition-related data attributes (data-starting-style and data-ending-style) across 10 components. The changes are purely documentation additions - creating new DataAttributes.ts files for components that had none, and updating existing files to include transition attributes. All corresponding generated JSON documentation files and the main components page have been updated to reflect these additions.

The implementation follows established patterns:

  • Transition attributes are imported from TransitionStatusDataAttributes for simple components
  • Drawer components use CommonPopupDataAttributes which includes both transition and open/closed state attributes
  • Generated documentation and MDX files are automatically updated to reflect the TypeScript changes

No functional changes to component behavior.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a documentation-only PR that adds missing transition data attribute documentation across components. All changes follow consistent patterns, properly reference shared enums from utility files, and the generated JSON files correctly reflect the TypeScript definitions. No behavioral changes to components.
  • No files require special attention

Important Files Changed

Filename Overview
packages/react/src/avatar/fallback/AvatarFallbackDataAttributes.ts Adds transition data attributes (starting-style, ending-style) for Avatar Fallback component
packages/react/src/avatar/image/AvatarImageDataAttributes.ts Adds transition data attributes (starting-style, ending-style) for Avatar Image component
packages/react/src/drawer/backdrop/DrawerBackdropDataAttributes.ts Adds transition and open/closed state data attributes for Drawer Backdrop component
packages/react/src/drawer/popup/DrawerPopupDataAttributes.ts Adds transition and open/closed state data attributes for Drawer Popup component
packages/react/src/drawer/viewport/DrawerViewportDataAttributes.ts Adds transition, open/closed, and nesting-related data attributes for Drawer Viewport component
packages/react/src/field/error/FieldErrorDataAttributes.ts Adds transition data attributes (starting-style, ending-style) to existing Field Error attributes
packages/react/src/tabs/panel/TabsPanelDataAttributes.ts Adds transition data attributes (starting-style, ending-style) to existing Tabs Panel attributes
docs/src/app/(docs)/react/components/page.mdx Updated component documentation with newly added transition data attributes

Last reviewed commit: cc0c756

/**
* Present when the drawer has other open drawers nested within it.
*/
nestedDialogOpen = 'data-nested-dialog-open',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: did you go for dialog here since there are other cases of this data attributes on other role="dialog" components?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this was incorrect as DrawerViewport doesn't have this variable. I've removed it (and if it did have it, it'd be named as drawer)

@atomiks atomiks force-pushed the codex/transition-status-data-attrs-docs branch 3 times, most recently from e8f7832 to 5d227a8 Compare February 16, 2026 10:03
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 16, 2026

Automatic reviews are disabled for this repository.

@atomiks atomiks force-pushed the codex/transition-status-data-attrs-docs branch from 5d227a8 to 21b248c Compare February 16, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: all components Widespread work has an impact on almost all components.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants