[all components][docs] Document missing transition data attributes#4098
[all components][docs] Document missing transition data attributes#4098atomiks wants to merge 2 commits intomui:masterfrom
Conversation
atomiks
commented
Feb 16, 2026
- I have followed (at least) the PR section of the contributing guide.
Bundle size report
Check out the code infra dashboard for more information about this PR. |
commit: |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Greptile SummaryThis PR documents previously missing transition-related data attributes ( The implementation follows established patterns:
No functional changes to component behavior. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: cc0c756 |
| /** | ||
| * Present when the drawer has other open drawers nested within it. | ||
| */ | ||
| nestedDialogOpen = 'data-nested-dialog-open', |
There was a problem hiding this comment.
Nitpick: did you go for dialog here since there are other cases of this data attributes on other role="dialog" components?
There was a problem hiding this comment.
No, this was incorrect as DrawerViewport doesn't have this variable. I've removed it (and if it did have it, it'd be named as drawer)
e8f7832 to
5d227a8
Compare
|
Automatic reviews are disabled for this repository. |
5d227a8 to
21b248c
Compare