[drawer] Ignore swipes without an attributed direction when using snap points - #5477
Open
atomiks wants to merge 3 commits into
Open
[drawer] Ignore swipes without an attributed direction when using snap points#5477atomiks wants to merge 3 commits into
atomiks wants to merge 3 commits into
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,219.53 ms +12.95 ms(+1.1%) | Renders: 76 (+0) | Paint: 1,922.31 ms +36.30 ms(+1.9%)
13 tests within noise — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
force-pushed
the
claude/drawer-snap-points-issue-f0647f
branch
from
August 13, 2026 04:10
bd14ad7 to
5b1a593
Compare
atomiks
marked this pull request as ready for review
August 13, 2026 04:22
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 13, 2026 04:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5471
With
snapPoints, the release logic decides to close from the vertical delta and release velocity alone. A mostly horizontal flick with a fast downward arc at lift passes those checks even thoughuseSwipeDismissnever attributed a swipe direction to the gesture. The viewport then commits the closing choreography (data-ending-style,data-swipe-dismiss, snap point set tonull), but the hook drops the release decision because it has no dismiss direction, soonOpenChangenever fires and the popup stays visually dismissed whileopenremainstrue.Changes
data-nested-drawer-swipingand a stale swipe progress.