[navigation menu] Keep focus on trigger when opening - #5479
Open
atomiks wants to merge 1 commit into
Open
Conversation
atomiks
added
type: bug
commit: |
Bundle size
PerformanceTotal duration: 1,462.15 ms -6.54 ms(-0.4%) | Renders: 76 (+0) | Paint: 2,267.70 ms -65.45 ms(-2.8%) No significant changes — details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
August 13, 2026 03:44
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
August 13, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5413
Opening Navigation Menu with the keyboard currently schedules focus into the first content link on the next animation frame. This makes Enter, Space, and ArrowDown behave like menu entry instead of a disclosure trigger.
Context
The APG disclosure navigation example treats arrow-key navigation as optional and keeps normal Tab navigation through the controls and links. We can therefore retain the composite arrow behavior familiar from Radix Navigation Menu without coupling keyboard opening to an automatic focus move.
As real-world precedents, Apple keeps focus on its disclosure control when opening the global navigation, while Stripe combines composite arrows with the behavior in this PR: ArrowDown opens the focused disclosure, focus remains on its trigger, and Tab enters the links.
Changes